Repository navigation
iOS VSyncClient's displayRefreshRate always return the maximum rate #185759
Description
Steps to reproduce
Spot by Gemini during a code review: #185737 (comment)
This was introduced by https://github.com/flutter/engine/pull/52104/changes#diff-ca0ba764dd3a3c6d10dfd05ea010d65973a4882b7f2549352367b97944a1fd8fL160-R151
Original code uses autorelease on DisplayLinkManager, which keeps it alive until next runloop. The new code could dealloc it eagerly since CADisplayLink doesn't retain the target.
Expected results
NA
Actual results
NA
Code sample
NA
Screenshots or Video
NA
Logs
NA
Flutter Doctor output
NA
Activity
cbracken commentedon Apr 29, 2026
The refactor that led to the final breakage was flutter-team-archive/engine#22194, which is where the ivar was eliminated. I think it was only a matter of time before this would have been triggered either way.
[iOS] Migrate DisplayLinkManager to a shared instance
[iOS] Migrate DisplayLinkManager to a shared instance
[iOS] Migrate DisplayLinkManager to a shared instance
[iOS] Migrate DisplayLinkManager to a shared instance
[iOS] Migrate DisplayLinkManager to a shared instance (flutter#189492)