Hot Reload does not update background isolate #20743

Activity

1. bkonyi

   added

   t: hot reloadReloading code during "flutter run"Reloading code during "flutter run"

   on Aug 17, 2018
2. zoechi

   added

   toolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.

   on Aug 20, 2018
3. zoechi commented on Dec 16, 2018

   

   zoechi

   on Dec 16, 2018

   Contributor

   More actions

   Similar to #18600

   👍React with 👍1Reacted by Joshua Leivenzon
4. zoechi

   added this to the GoalsThis milestone has been deleted milestone on Dec 16, 2018
5. zoechi

   added

   dependency: dartDart team may need to help usDart team may need to help us

   on Dec 16, 2018
6. bkonyi

   self-assigned this

   on Jan 30, 2019
7. jonahwilliams commented on Mar 6, 2020

   

   jonahwilliams

   on Mar 6, 2020

   Contributor

   More actions

   What I get when running this locally is that we attempt to restart all isolates, but perhaps the Android Alarm Manager itself is blocking the restart of the background isolate:

   
   Performing hot restart...                                              ⣽[Isolate isolates/2476543108908847, Isolate isolates/84157653816603]
   [_flutterView/0x7a7546bf20, _flutterView/0x7a7546db20]
          ⣟I/AlarmService(17594): AlarmService started!
           
   Restarted application in 1,298ms.
   I/flutter (17594): Rainbow Monkey has started
   W/AlarmService(17594): Attempted to start a duplicate background isolate. Returning...
   

   This corresponds to https://github.com/flutter/plugins/blob/e61e9d45bcaadc3e409d529d30735cb4db75c5c5/packages/android_alarm_manager/android/src/main/java/io/flutter/plugins/androidalarmmanager/AlarmService.java#L58
8. bkonyi commented on Mar 9, 2020

   

   bkonyi

   on Mar 9, 2020

   ContributorAuthor

   More actions

   Yeah, I think the alarm manager plugin needs to be updated to actually check the running state of the background isolate instead of checking if the variable containing the background isolate is null or not.
9. kf6gpe

   added

   P2Important issues not at the top of the work listImportant issues not at the top of the work list

   on May 29, 2020
10. Hixie

    removed this from the None.This milestone has been deleted milestone on Aug 17, 2020
11. mkustermann commented on Sep 9, 2021

    

    mkustermann

    on Sep 9, 2021

    Member

    More actions

    As part of dart-lang/sdk#36097 we have fixed issues with hot-reload and isolates (e.g. dart-lang/sdk#36648) - all isolates are reloaded together. I suspect it also addresses this issue.

    If this is still an issue for anyone on master branch, please file a new issue and CC me.
12. mkustermann

    closed this as completedon Sep 9, 2021
13. github-actions commented on Sep 23, 2021

    

    github-actionsbot

    on Sep 23, 2021

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
14. github-actions

    locked as resolved and limited conversation to collaborators on Sep 23, 2021