Skip to content

Make the android_views integration test depend on goldens through a github url #20959

Closed

Description

@amirh

It currently depends on the golden package from bin/cache which involved complexities for making sure the local copy is available before running the test.

@xster just pointed out that I could just depend on a github url.

Activity

  1. self-assigned this
    on Aug 23, 2018
  2. added
    a: tests"flutter test", flutter_test, or one of our tests
    on Sep 2, 2018
  3. eseidelGoogle commented on Jan 10, 2020

    @eseidelGoogle
    Contributor

    Is this TODO still valid an useful Amir?

    Looks like it uses github now:
    https://github.com/flutter/flutter/blob/master/dev/integration_tests/android_views/pubspec.yaml
    Speculatively closing. Obviously re-open if I've misunderstood. Thanks!

  4. amirh commented on Jan 10, 2020

    @amirh
    ContributorAuthor

    You're right, sorry forgot to close this one.

  5. github-actions commented on Aug 24, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  6. locked as resolved and limited conversation to collaborators on Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

a: tests"flutter test", flutter_test, or one of our testsc: contributor-productivityTeam-specific productivity, code health, technical debt.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions