Repository navigation
Port sky viewer to new view manager. #223
Description
Activity
Comment by abarth
Saturday Oct 24, 2015 at 04:48 GMT
This looks great. LGTM.
At some point, once the dust has settled on the new view manager, I'd like to refactor/rewrite this code. It should be possible to delete all this code and integrate mojo with the
//sky/shellembedding of//sky/engine. Essentially, we should be able to treat mojo as just another host OS for the flutter shell. That's probably the time to rename all this stuff to flutter, and we'll end up with aflutter_shell.mojo.Comment by j9brown
Saturday Oct 24, 2015 at 05:21 GMT
Yup. Sounds good to me.
On Fri, Oct 23, 2015, 9:48 PM Adam Barth [email protected] wrote:
This looks great. LGTM.
At some point, once the dust has settled on the new view manager, I'd like
to refactor/rewrite this code. It should be possible to delete all this
code and integrate mojo with the //sky/shell embedding of //sky/engine.
Essentially, we should be able to treat mojo as just another host OS for
the flutter shell. That's probably the time to rename all this stuff to
flutter, and we'll end up with a flutter_shell.mojo.—
Reply to this email directly or view it on GitHub
flutter-team-archive/engine#1771 (comment).This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.- locked as resolved and limited conversation to collaborators
on Sep 7, 2021
Saturday Oct 24, 2015 at 02:48 GMT
Originally opened as flutter-team-archive/engine#1771
Requires a fresh roll from Mojo repo before submitting.
j9brown included the following code: https://github.com/flutter/engine/pull/1771/commits