Skip to content

Only 24dp material design icons are included #235

Closed

Description

@FlutterIssues

Issue by ianloic
Monday Oct 26, 2015 at 23:02 GMT
Originally opened as https://github.com/flutter/engine/issues/1817


When I try to reference a material.Icon with a size of 18, 36 or 48 I get an error like:

Requested asset 'toggle/drawable-xxhdpi/ic_star_black_18dp.png' does not exist.

even though those are legitimate material icon sizes.

Activity

  1. added this to the milestone on Nov 9, 2015
  2. FlutterIssues commented on Nov 9, 2015

    @FlutterIssues
    Author

    Comment by abarth
    Tuesday Oct 27, 2015 at 04:04 GMT


    I think you can just add these sizes to this line of code:

    https://github.com/flutter/tools/blob/master/lib/src/commands/build.dart#L20

    We need a better system for determining which assets to include in your FLX. At a minimum, we could make this configurable in the flutter.yaml file. In the best case, we'd have a way to automatically detect which assets you needed by statically analyzing your code (e.g., by having a constant for each asset and applying tree shaking).

  3. FlutterIssues commented on Nov 9, 2015

    @FlutterIssues
    Author

    Comment by IvBaranov
    Friday Nov 06, 2015 at 16:33 GMT


    I am not sure I should start new issue so:
    Demo project my_app prints:
    [WARNING:asset_bundle_impl.cc(45)] Requested asset 'content/drawable-xxhdpi/ic_add_white_24dp.png' does not exist.

  4. self-assigned this
    on Nov 17, 2015
  5. abarth commented on Nov 17, 2015

    @abarth
    Contributor

    Adding all the sizes makes the stocks FLX about 50KB bigger. Probably the right trade-off for now.

  6. added a commit that references this issue on Nov 17, 2015
    a8ab3d6
  7. github-actions commented on Aug 17, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  8. locked as resolved and limited conversation to collaborators on Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

customer: fuchsiaframeworkflutter/packages/flutter repository. See also f: labels.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions