Explore more retained rendering #23535

Activity

1. liyuqian

   added

   c: new featureNothing broken; request for a new capabilityNothing broken; request for a new capability

   on Oct 25, 2018
2. liyuqian

   self-assigned this

   on Oct 25, 2018
3. zoechi

   added

   engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.

   c: performanceRelates to speed or footprint issues (see "perf:" labels)Relates to speed or footprint issues (see "perf:" labels)

   p: framework

   frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.

   and removed

   p: framework

   on Dec 11, 2018
4. liyuqian

   added a commit that references this issue on Feb 4, 2019

   Retained rendering in Fuchsia PhysicalShapeLayer (#6558)

   ...

   eaae8a6
5. liyuqian

   added this to the GoalsThis milestone has been deleted milestone on Aug 7, 2019
6. Hixie commented on Jan 9, 2020

   

   Hixie

   on Jan 9, 2020

   Contributor

   More actions

   @liyuqian Can you elaborate on "Explore if we can add an option to RepaintBoundary and improve performance significantly by using snapshot of a layer subtree that's not a child of an OpacityLayer"?
7. liyuqian commented on Jan 10, 2020

   

   liyuqian

   on Jan 10, 2020

   ContributorAuthor

   More actions

   @Hixie : I was thinking about raster caching the whole layer subtree for either a TransformLayer (#24627), or an ImageFiltered layer. See #32662 for more details. @flar has been doing a lot of work recently (including introducing the new ImageFiltered layer flutter-team-archive/engine#14491). So @flar may be able to provide more details.
8. liyuqian

   removed their assignment

   on Jan 10, 2020
9. flar commented on Jan 10, 2020

   

   flar

   on Jan 10, 2020

   Contributor

   More actions

   ImageFiltered does cache if its child layer is stable, but it is only stable if you use a RepaintBoundary.

   Right now we recreate a lot of layers even if nothing changes. I'm still digging into our strategies there, but a lot of it probably hinges on the way that we manage Picture layers. They are recreated if the part of the tree they are in is visited even if they themselves don't involve any Widgets/RenderObjects that changed.

   They are also created from groups of RenderObjects that are next to each other in a depth-first traversal of the tree, but that don't necessarily all descend from a single parent. If the picture was generated from a single RenderObject then we might be able to just check a flag on that object, but pictures are actually generated from a group of them and since they aren't aware that they are all contributing to the same picture together, we end up with no specific flag that can be checked to see if the picture is dirty and so we pessimistically recreate it every time we traverse the tree.

   I have a change pending that can try to make a better determination if a picture is actually changing, but it is more reactive than I'd like and it doesn't have as much impact as I'd like to see. I'm still investigating its potential and thinking of alternate solutions. A preliminary version of it can be seen in a branch on my fork of the framework repo in this commit: flar@bc131bf

   If we can get our layers to be reused more then it becomes a lot more feasible to cache layer renderings in the engine with a few lines of code in the engine layers and potentially without requiring developers to use RepaintBoundary all the time.
10. kf6gpe

    added

    P2Important issues not at the top of the work listImportant issues not at the top of the work list

    on May 29, 2020
11. Hixie

    removed this from the None.This milestone has been deleted milestone on Aug 17, 2020
12. flutter-triage-bot

    added

    multiteam-retriage-candidate

    team-engineOwned by Engine teamOwned by Engine team

    triaged-engineTriaged by Engine teamTriaged by Engine team

    on Jul 7, 2023
13. Hixie

    removed

    multiteam-retriage-candidate

    on Mar 6, 2024
14. jonahwilliams commented on Aug 13, 2024

    

    jonahwilliams

    on Aug 13, 2024

    Contributor

    More actions

    Impeller is moving away from full scene or layer based caching. Closing as obsolete.
15. jonahwilliams

    closed this as completedon Aug 13, 2024
16. github-actions commented on Aug 27, 2024

    

    github-actionsbot

    on Aug 27, 2024 – with GitHub Actions

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
17. github-actions

    locked as resolved and limited conversation to collaborators on Aug 27, 2024