Skip to content

Create an Add-to-App devicelab test for iOS #24117

Closed

Description

@dnfield

Recent changes to support Add2App broke some existing functionality that we test internally.

We should have a test in device lab to cover these scenarios.

/cc @cbracken @chinmaygarde @matthew-carroll @mit-mit @amirh (maybe something for maps/webview would make sense here?)

Activity

  1. added
    a: tests"flutter test", flutter_test, or one of our tests
    platform-iosiOS applications specifically
    e: embedderUsers of the Embedder API
    a: existing-appsIntegration with existing apps via the add-to-app flow
    on Nov 8, 2018
  2. self-assigned this
    on Nov 8, 2018
  3. modified the milestones: , bucket11 on Nov 8, 2018
  4. dnfield commented on Nov 21, 2018

    @dnfield
    ContributorAuthor

    Initial implementation is here: https://github.com/flutter/ios_add2app

    Still needs to be tied into our testing infra to get run on commits. One problem with doing that is until flutter-team-archive/engine#6879 is resolved, one of the tests in here will fail.

  5. dnfield commented on Jan 23, 2019

    @dnfield
    ContributorAuthor

    Engine bits have landed that make this make more sense.

    I'm inclined to add this to the Mac chromebot Engine post commit, although it'd be really nice if we could do it pre-commit, which would requrie adding a test to build the engine on a Mac pre-commit, which would be a pretty long test 😦

  6. modified the milestones: February 2019, on Feb 6, 2019
  7. changed the title [-]Create an Add2App devicelab test for iOS[/-] [+]Create an Add-to-App devicelab test for iOS[/+] on Feb 6, 2019
  8. modified the milestones: , April 2019 on Feb 6, 2019
  9. github-actions commented on Aug 31, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  10. locked as resolved and limited conversation to collaborators on Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

a: existing-appsIntegration with existing apps via the add-to-app flowa: tests"flutter test", flutter_test, or one of our testsc: contributor-productivityTeam-specific productivity, code health, technical debt.e: embedderUsers of the Embedder APIplatform-iosiOS applications specificallywaiting for PR to land (fixed)A fix is in flight

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions