Skip to content

Updating Google Maps options needs a way to fail #24327

Open

Description

@amirh

Right now we try to update the options and always complete the method channel invocation with a success.
We should refactor this a bit and relay update errors back to the Dart side.

Activity

  1. added
    c: new featureNothing broken; request for a new capability
    p: mapsGoogle Maps plugin
    on Nov 14, 2018
  2. added this to the milestone on Nov 14, 2018
  3. amirh commented on Dec 5, 2018

    @amirh
    ContributorAuthor

    Some more context: setting the "MyLocationEnabled" property can fail if the app doesn't have location permissions.

  4. garfieldcoked commented on Feb 17, 2019

    @garfieldcoked
  5. amirh commented on Feb 19, 2019

    @amirh
    Author
  6. garfieldcoked commented on Feb 21, 2019

    @garfieldcoked
  7. garfieldcoked commented on Feb 22, 2019

    @garfieldcoked
  8. added
    P2Important issues not at the top of the work list
    on May 29, 2020
  9. removed this from the milestone on Aug 17, 2020
  10. stuartmorgan-g commented on Feb 23, 2024

    @stuartmorgan-g
    Contributor

    This came up again in developing flutter/packages#6192, and I had to work around it there.

    It's not clear to me how to make this fail given the platform view creation, unless we start with a dummy view, and then have a separate call to populate that view with a map. Doing that could confuse some of our Android platform view logic though (where we make decisions about hosting mode based on examining the view hierarchy).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listc: new featureNothing broken; request for a new capabilityp: mapsGoogle Maps pluginpackageflutter/packages repository. See also p: labels.team-ecosystemOwned by Ecosystem teamtriaged-ecosystemTriaged by Ecosystem team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions