Crash if you reuse a PictureRecorder or Canvas

import 'dart:ui';
void main() {
  Rect bounds = new Rect.fromLTWH(0.0, 0.0, 1.0, 1.0);
  PictureRecorder recorder = new PictureRecorder();
  Canvas c1 = new Canvas(recorder, bounds);
  Picture p1 = recorder.endRecording();
  Canvas c2 = new Canvas(recorder, bounds); // should throw here
  Picture p2 = recorder.endRecording(); // currently crash here
}

I would instead expect an exception when creating c2.

~~(Also I'd expect isRecording to throw in that case too.)~~

I just ran into a similar crash:

import 'dart:ui';

void main() {
  Rect bounds = new Rect.fromLTWH(0.0, 0.0, 1.0, 1.0);
  PictureRecorder recorder = new PictureRecorder();
  Canvas c1 = new Canvas(recorder, bounds);
  c1.save();
  Picture p1 = recorder.endRecording();
  c1.restore(); // should throw here, currently crash here
}

That second one is actually pretty serious since it's one you'll run into if you forget to make your render object composited, which is an easy error to make.

We should probably address both of these so that people experimenting with layers don't accidentally crash the engine.

~~https://fuchsia-review.googlesource.com/c/34829/~~

https://fuchsia-review.googlesource.com/c/35742/

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

Navigation Menu

Repository navigation

Crash if you reuse a PictureRecorder or Canvas #2531

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Crash if you reuse a PictureRecorder or Canvas #2531

Description

Activity

Hixie commented on Mar 9, 2016

Hixie commented on Jun 12, 2017

Hixie commented on Jun 15, 2017

Hixie commented on Jun 22, 2017

github-actions commented on Aug 17, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions