Repository navigation
[Text feature] Underline Skip Descenders #28704
Description
It would be really great (read, somewhat necessary) to be able to:
- adjust the underline thickness
- toggle skipping descenders
I saw some issues around exposing Skia text metrics but I'm not sure if these were specifically covered off.
Either way, I'd really love to see them.
Activity
dnfield commentedon Mar 1, 2019
/cc @GaryQian @justinmc
GaryQian commentedon Mar 1, 2019
LibTxt already supports a multiplier. We should be able to expose it to the framework fairly easily.
@Hixie any thoughts on simply adding a property to TextStyle called decorationThickness or decorationWeight?
lukef commentedon Mar 1, 2019
I'm not sure of how tightly libtxt is attached to Skia but i did see methods on the SKTextBlob for the skip ascenders feature but I need to dig into the engine to see how the text rendering is being implemented today. I'm assuming it is available more generically as it is present? I'm guessing libtxt doesn't implement it though.
GaryQian commentedon Mar 13, 2019
Decoration thickness has landed.
So LibTxt currently handles all of the decoration drawing itself. It would be a moderate/significant change to fully let skia handle this in order to implement skip descenders. I can do some exploration to see how much it would take.
lukef commentedon Mar 13, 2019
@GaryQian - if you need a hand let me know. Would be great to have it.
[-]Underline decoration feature suggestions[/-][+][Text feature] Underline Skip Descenders[/+]