Skip to content

Slider thumb label is unreadable if accent color is bright and primary color is dark #28706

Description

@Hixie

Slider.label's docs say that the label is painted using ThemeData.accentTextTheme.body2, which appears to be correct (I didn't check), but unfortunately the thumb itself is painted using the primary color, which is not guaranteed to contrast well with the accentTextTheme.

I assume it's supposed to be using the primaryTextTheme? Or the thumb should use the accent color?

cc @HansMuller @gspencergoog

Activity

  1. added
    frameworkflutter/packages/flutter repository. See also f: labels.
    p: material_uimaterial_ui package in flutter/packages
    c: API breakBackwards-incompatible API changes
    on Mar 1, 2019
  2. added this to the milestone on Mar 1, 2019
  3. HansMuller commented on Mar 1, 2019

    @HansMuller
    Contributor
  4. clocksmith commented on Mar 1, 2019

    @clocksmith
    Contributor

    Slider thumb color as primary is correct. Value indicator is also primary color, but the text should be onPrimary from the color scheme.

  5. self-assigned this
    on Mar 1, 2019
  6. clocksmith commented on Mar 1, 2019

    @clocksmith
    Contributor

    I am working on a few updates that are awaiting verification from design that will be done in a single breaking change (thumb size, thumb gap color, etc)

  7. github-actions commented on Aug 14, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  8. locked as resolved and limited conversation to collaborators on Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

c: API breakBackwards-incompatible API changesframeworkflutter/packages/flutter repository. See also f: labels.p: material_uimaterial_ui package in flutter/packages

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions