Repository navigation
Replace the legacy pointer input event handling with PointerPackets #288
Description
Tuesday Nov 10, 2015 at 00:33 GMT
Originally opened as flutter-team-archive/engine#2021
With this change we no longer need engine/core/events and its IDL bindings.
jason-simmons included the following code: https://github.com/flutter/engine/pull/2021/commits
Activity
FlutterIssues commentedon Nov 10, 2015
Tuesday Nov 10, 2015 at 01:18 GMT
lgtm. I really like flushing all pending pointer events in one go.
I will update the iOS platform stuff once this lands.
FlutterIssues commentedon Nov 10, 2015
Tuesday Nov 10, 2015 at 02:42 GMT
LGTM
FlutterIssues commentedon Nov 10, 2015
Tuesday Nov 10, 2015 at 02:49 GMT
You'll also need to update
//services/sky, which is what builds thesky_viewer.mojoapp that runs inside MojoShell. It's still using the legacy view manager, so you'll probably need to create pointer packets out of whatever input events the legacy view manager is using.FlutterIssues commentedon Nov 10, 2015
Tuesday Nov 10, 2015 at 05:32 GMT
sky_viewer.mojo doesn't talk to the legacy view manager (or any other view manager), it talks to native viewport. The input events it gets are https://github.com/domokit/mojo/blob/master/mojo/services/input_events/interfaces/input_events.mojom instances from the NativeViewportEventDispatcher interface: https://github.com/domokit/mojo/blob/master/mojo/services/native_viewport/interfaces/native_viewport.mojom#L50
FlutterIssues commentedon Nov 10, 2015
Tuesday Nov 10, 2015 at 14:43 GMT
@jamesr Yes, you're right. At some point, we should probably teach NativeViewportEventDispatcher (and eventually Mozart) about pointer packets.
Hixie commentedon Nov 11, 2015
@jason-simmons This is done now right?
jason-simmons commentedon Nov 11, 2015
This has landed.
github-actions commentedon Sep 7, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.