didChangeDependencies docs don't specify where to call super #28925

Activity

1. Piinks

   added

   d: api docsIssues with https://api.flutter.dev/Issues with https://api.flutter.dev/

   on Jun 24, 2019
2. pushpendraKh commented on Aug 20, 2019

   

   pushpendraKh

   on Aug 20, 2019

   More actions

   any update on this?
3. iapicca

   added

   documentation

   frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.

   passed first triage

   on Jan 14, 2020
4. goderbauer

   added

   P2Important issues not at the top of the work listImportant issues not at the top of the work list

   on Feb 7, 2023
5. Hixie

   removed

   documentation

   on Jul 5, 2023
6. flutter-triage-bot

   added

   team-frameworkOwned by Framework teamOwned by Framework team

   triaged-frameworkTriaged by Framework teamTriaged by Framework team

   on Jul 8, 2023
7. Hixie

   removed

   passed first triage

   on Jul 8, 2023
8. jhon2520 commented on Aug 11, 2024

   

   jhon2520

   on Aug 11, 2024

   More actions

   Any update ?
9. navaronbracke commented on Mar 24, 2026

   

   navaronbracke

   on Mar 24, 2026

   Contributor

   More actions

   When looking at the framework itself, it looks like it is also not consistent: https://github.com/search?q=repo%3Aflutter%2Fflutter%20didChangeDependencies()&type=code

   However, considering it is a "constructive" lifecycle method, I would expect implementers to have to call the super method first in the override.

   👍React with 👍1Reacted by Loïc Sharma
10. fahaddoc

    added a commit that references this issue on May 4, 2026

    Document super call order for State.didChangeDependencies

    ...

    This issue will close once commit 1a05b8a is merged into the 'master' branch.

    1a05b8a
11. fahaddoc

    added a commit that references this issue on Jul 29, 2026

    Document super call order for State.didChangeDependencies

    ...

    This issue will close once commit e90043d is merged into the 'master' branch.

    e90043d
12. auto-submit

    closed this as completedin #185945on Aug 5, 2026
13. pull

    added a commit that references this issue on Aug 5, 2026

    Document super call order for State.didChangeDependencies (flutter#18…

    ...

    This issue will close once commit 8ef2fe4 is merged into the 'master' branch.

    8ef2fe4
14. github-actions commented on Aug 19, 2026

    

    github-actionsbot

    on Aug 19, 2026 – with GitHub Actions

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
15. github-actions

    locked as resolved and limited conversation to collaborators on Aug 19, 2026