Repository navigation
Remove Java keyboard static #299
Description
When there are multiple PlatformViews, we don't have a way for Mojo service clients to specific which view they are associated with. There's a comment in PlatformViewAndroid:
// TODO(eseidel): We need per-view services!
Activity
[-]Support for view-specific services[/-][+]Support for view-specific Mojo services[/+][-]Support for view-specific Mojo services[/-][+]Remove Java keyboard static[/+]abarth commentedon Nov 18, 2015
We now support view-specific services. The task that remains here is to remove the statics and provide the keyboard service directly on the view
krisgiesing commentedon Nov 25, 2015
Flutter side is merged, working on Mojo side now (since the code is duplicated there too).
krisgiesing commentedon Nov 26, 2015
Just realized there is similar static state in InputServiceImpl.java. I couldn't find the equivalent to this class on the Flutter side, not sure if it's a mojo-specific issue.
abarth commentedon Nov 26, 2015
There's no equivalent in Flutter.
abarth commentedon Dec 5, 2015
I believe @krisgiesing did this.
krisgiesing commentedon Dec 6, 2015
I did remove the static on the Flutter side. On the Mojo side, after talking with Jeff Brown it appears that it's not worth trying to remove it until his view manager code is in place.
abarth commentedon Dec 6, 2015
We should probably change the
roll.pyscript to not clobber Flutter's keyboard impl with the version from mojo.git then. In the most recent roll, I needed to manually restore Flutter's copy.krisgiesing commentedon Dec 6, 2015
Ugh, I didn't realize this would occur. Let's sync on Monday and I can put something in place to avoid this problem.
abarth commentedon Dec 6, 2015
I think we just need to delete this line:
https://github.com/flutter/engine/blob/master/sky/tools/roll/roll.py#L87
Hixie commentedon Dec 28, 2015
What's the story with
KeyboardServiceImpl.javanow then? Does Flutter own its own copy or is the Mojo version the master version?Hixie commentedon Dec 28, 2015
I assume based on flutter-team-archive/engine@3c47bd4 that Flutter has its own copy now.
abarth commentedon Dec 28, 2015
Correct
github-actions commentedon Sep 6, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.