Add desktop shell support for text navigation key combinations

On macOS, typing cmd+right invokes moveToRightEndOfLine: These methods are already received by doCommandBySelector: so we we just need to implement the logic.

On glfw we could use modifier flags https://www.glfw.org/docs/latest/group__mods.html#ga14994d3196c290aaa347248e51740274

To clarify, the original description here is one such shortcut, but there are many that we should support across the desktop platforms. Other examples include things like forward/back word, delete word, etc.

Here's a list I compiled for NSResponder:

(void)moveBackwardAndModifySelection nullable id)sender;
(void)moveForwardAndModifySelection nullable id)sender;
(void)moveWordForwardAndModifySelection nullable id)sender;
(void)moveWordBackwardAndModifySelection nullable id)sender;
(void)moveUpAndModifySelection nullable id)sender;
(void)moveDownAndModifySelection nullable id)sender;
(void)moveToBeginningOfLineAndModifySelection nullable id)sender;
(void)moveToEndOfLineAndModifySelection nullable id)sender;
(void)moveToBeginningOfParagraphAndModifySelection nullable id)sender;
(void)moveToEndOfParagraphAndModifySelection nullable id)sender;
(void)moveToEndOfDocumentAndModifySelection nullable id)sender;
(void)moveToBeginningOfDocumentAndModifySelection nullable id)sender;
(void)pageDownAndModifySelection nullable id)sender;
(void)pageUpAndModifySelection nullable id)sender;
(void)moveParagraphForwardAndModifySelection nullable id)sender;
(void)moveParagraphBackwardAndModifySelection nullable id)sender;
(void)moveRightAndModifySelection nullable id)sender;
(void)moveLeftAndModifySelection nullable id)sender;
(void)moveWordRightAndModifySelection nullable id)sender;
(void)moveWordLeftAndModifySelection nullable id)sender;
(void)moveToLeftEndOfLineAndModifySelection nullable id)sender NS_AVAILABLE_MAC(10_6);
(void)moveToRightEndOfLineAndModifySelection nullable id)sender NS_AVAILABLE_MAC(10_6);

See #34949 for some more specific cases that should be supported.

Paste shortcuts do not work either.

I'm curious: why do these key bindings need to be added on the engine side? Why can't we handle these keys on the framework side and just have it tell the shell how to modify the selection, etc.?

The triaged-desktop label is irrelevant if there is no team-desktop label or fyi-desktop label.

Navigation Menu

Repository navigation

Add desktop shell support for text navigation key combinations #30725

44 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Add desktop shell support for text navigation key combinations #30725

Description

Activity

stuartmorgan-g commented on May 6, 2019

krisgiesing commented on May 6, 2019

stuartmorgan-g commented on Jun 26, 2019

gazialankus commented on Aug 5, 2019

gspencergoog commented on Nov 4, 2019

44 remaining items

flutter-triage-bot commented on Jun 7, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions