Repository navigation
Remove asserts from Android embedding #31928
Description
We've discussed this before - the Android linter says these are unreliable. I'm now working on a bug that appears to be suffering from this (#31139). We have code that asserts the transform we're about to pass isn't null, but this makes me suspect there are many things we're asserting that are never triggered.
We should follow the linter suggestion and use if (BuildConfig.DEBUG) instead and make sure we're setting that configuration properly for debug versions of the engine.
Activity
matthew-carroll commentedon May 1, 2019
@dnfield, agreed. I've brought this up in the past trying to determine whether my understanding that asserts shouldn't exist was correct, or if I was missing something and that these asserts had a place. I never got an answer on that so I tried not to delete them. But if this settles that question then I'd be happy to start replacing them as I come across them in the embedding.
dnfield commentedon May 1, 2019
See https://issuetracker.google.com/issues/36988757 for some more details
matthew-carroll commentedon May 1, 2019
Are you wanting to migrate all this with one PR, or should I also make these changes progressively?
dnfield commentedon May 1, 2019
I'm starting with AccessibilityBridge.java. There aren't many more than in there, I could do them in one PR unless that will cause merge problems for your embedding patches.
matthew-carroll commentedon May 1, 2019
Should be fine.
dnfield commentedon May 2, 2019
This is getting hung up on some buildroot related issues right now. Still looking for either a work around or a fix for buildroot to define the debug constant(s).
github-actions commentedon Aug 30, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.