Skip to content

ScrollPosition.animateTo should build last frame before resolving animation #32054

Closed

Description

@shihaohong

Currently, there are no tests to ensure that when TabBarView is warping, the last frame of _pageController.animateToPage is built before the final page swapping is completed. This used to cause an exception to be thrown with nested TabBarViews (see #31581 for context).

There could probably be a robust fix to ScrollPosition.animateTo to ensure that the last frame is built prior to completing the animation, and a test to verify that this occurs properly.

Activity

  1. added
    frameworkflutter/packages/flutter repository. See also f: labels.
    p: material_uimaterial_ui package in flutter/packages
    on May 3, 2019
  2. changed the title [-]Need to verify TabBarView's `animateTo` builds it's last frame[/-] [+]Need to verify `animateTo`/`animateToPage` builds its last frame[/+] on May 3, 2019
  3. changed the title [-]Need to verify `animateTo`/`animateToPage` builds its last frame[/-] [+]ScrollPosition.animateTo should build last frame before resolving animation[/+] on May 3, 2019
  4. github-actions commented on Mar 30, 2023

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  5. locked as resolved and limited conversation to collaborators on Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    c: proposalA detailed proposal for a change to Flutterframeworkflutter/packages/flutter repository. See also f: labels.p: material_uimaterial_ui package in flutter/packages

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions