Performance audit embedding Flutter view initialization time #32945

Activity

1. xster

   added

   engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.

   c: performanceRelates to speed or footprint issues (see "perf:" labels)Relates to speed or footprint issues (see "perf:" labels)

   a: existing-appsIntegration with existing apps via the add-to-app flowIntegration with existing apps via the add-to-app flow

   on May 17, 2019
2. gaaclarke commented on Jul 19, 2019

   

   gaaclarke

   on Jul 19, 2019

   Last edited by gaaclarke

   Member

   More actions

   We've done a few things that make this better:

   1. ShaderWarmUp works in add to app now: Made Picture::toImage happen on the IO thread with no need for an onscreen surface. flutter-team-archive/engine#9813
   2. Added synchronization with main thread: Synchronize main thread and gpu thread for first render frame flutter-team-archive/engine#9506
   3. Fixed the first frame callback for add to app case: ios: Fixed the callback for the first frame so that it isn't predicated on having a splash screen. flutter-team-archive/engine#9952
   4. Made ShaderWarmUp faster: Sped up shader warmup by only drawing on a 100x100 surface #36482

   Here is a recent sample from app startup time (tested against PR 36482)
   
   little.json.gz
   (Sample taken in iPhone SE)

   ~80ms is spent in FontCollection::FindFontFamilyInManagers. That seems to be the place currently with a lot of opportunity outside of Skia. We should use a more complete profiler to introspect into Skia as well.
3. xster commented on Jul 19, 2019

   

   xster

   on Jul 19, 2019

   MemberAuthor

   More actions

   This is all in profile mode right? 300ms of pure dart code for one frame does seem a bit intense. Though given a prewarm'ed engine (on which we called runWithEntrypoint ahead of time), this cost is hidden right?
4. gaaclarke commented on Jul 19, 2019

   

   gaaclarke

   on Jul 19, 2019

   Member

   More actions

   An instruments profile confirms there is a lot of work being done with fonts:
   
   flutterstartup.trace.zip
5. gaaclarke commented on Jul 19, 2019

   

   gaaclarke

   on Jul 19, 2019

   Member

   More actions

   This is all in profile mode right? 300ms of pure dart code for one frame does seem a bit intense. Though given a prewarm'ed engine (on which we called runWithEntrypoint ahead of time), this cost is hidden right?

   Yep, both samples are in profile mode.
6. xster commented on Jul 19, 2019

   

   xster

   on Jul 19, 2019

   MemberAuthor

   More actions

   Also cc @GaryQian @jason-simmons for any potential optimizations on the font manager (potentially doing things before the first Dart frame)
7. kf6gpe

   added this to the December 2019 (Add-to-App) milestone on Aug 29, 2019
8. Hixie

   modified the milestones: December 2019 (Add-to-App), OverdueThis milestone has been deleted, GoalsThis milestone has been deleted on Jan 7, 2020
9. kf6gpe

   added

   P2Important issues not at the top of the work listImportant issues not at the top of the work list

   on May 29, 2020
10. Hixie

    removed this from the None.This milestone has been deleted milestone on Aug 17, 2020
11. TahaTesser

    added

    passed first triage

    on Dec 4, 2020
12. flutter-triage-bot

    added

    team-engineOwned by Engine teamOwned by Engine team

    triaged-engineTriaged by Engine teamTriaged by Engine team

    on Jul 8, 2023
13. Hixie

    removed

    passed first triage

    on Jul 8, 2023
14. jonahwilliams commented on Aug 30, 2024

    

    jonahwilliams

    on Aug 30, 2024

    Contributor

    More actions

    Seems like we did do the audit. Hopefully any follow up tasks were filled and or completed
15. jonahwilliams

    closed this as completedon Aug 30, 2024
16. github-actions commented on Sep 13, 2024

    

    github-actionsbot

    on Sep 13, 2024 – with GitHub Actions

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
17. github-actions

    locked as resolved and limited conversation to collaborators on Sep 13, 2024