Skip to content

Revive the "set marker icon" sample for Google Maps #33438

Closed

Description

@amirh

Following a breaking change to the ImageStream API in the framework(#32936) the Google Maps plugin sample app needs to be updated to the new API.

As we make sure to keep plugins working agains stable we cannot apply the update before the framework change makes it to stable. But if we do not apply the change, the plugins' CI is red as it's running with master.

For now, I'm updating the sample app to the new framework API, but commenting out the "set marker icon" sample until the framework change makes it to master.

Once the framework change makes it to stable we should uncomment that code.

Activity

  1. added this to the July 2019 milestone on May 28, 2019
  2. self-assigned this
    on May 28, 2019
  3. amirh commented on May 28, 2019

    @amirh
    ContributorAuthor
  4. modified the milestones: July 2019, on Aug 6, 2019
  5. modified the milestones: , , on Aug 14, 2019
  6. amreniouinnovent commented on Aug 30, 2019

    @amreniouinnovent

    @amirh I think #32936 is merged to master
    I tested the uncommented code and it is working for me

  7. kleeb commented on Nov 28, 2019

    @kleeb

    for me as well

  8. 9 remaining items

  9. stuartmorgan-g commented on Jun 16, 2021

    @stuartmorgan-g
    Contributor

    @amirh @stuartmorgan Just wondering if this issue can be closed based on above verification, or wait till the PR is landed ? flutter/plugins#2443

    I don't understand the question. Nobody has verified that the sample code is no longer commented out—they can't possibly have, because it isn't—which is what this bug is tracking.

  10. added and removed
    waiting for responseThe Flutter team cannot make further progress on this issue until the original reporter responds
    on Jul 9, 2021
  11. stuartmorgan-g commented on Jul 4, 2025

    @stuartmorgan-g
    Contributor
  12. added
    r: fixedIssue is closed as already fixed in a newer version
    on Jul 7, 2025
  13. github-actions commented on Jul 21, 2025

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  14. locked as resolved and limited conversation to collaborators on Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listd: examplesSample code and demosp: mapsGoogle Maps pluginpackageflutter/packages repository. See also p: labels.r: fixedIssue is closed as already fixed in a newer versionteam-ecosystemOwned by Ecosystem teamtriaged-ecosystemTriaged by Ecosystem team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions