Skip to content

[Breaking Change] remove the FadeInImage.placeholderSemanticLabel property #33480

Closed

Description

@tvolkert

This property was added in #28799 for the sake of completeness (the bug
it fixed was the lack of any semantic label support in FadeInImage), but a
placeholder is a transient visual artifact, not something that affects the
underlying semantic meaning of the image. Thus, I think it's ill-advised to
have a separate semantic label while the image is loading.

Activity

  1. added
    frameworkflutter/packages/flutter repository. See also f: labels.
    on May 29, 2019
  2. added this to the May 2019 milestone on May 29, 2019
  3. self-assigned this
    on May 29, 2019
  4. changed the title [-]Remove the `FadeInImage.placeholderSemanticLabel` property[/-] [+][Breaking Change] remove the `FadeInImage.placeholderSemanticLabel` property[/+] on Jun 2, 2019
  5. tvolkert commented on Jun 2, 2019

    @tvolkert
    ContributorAuthor

    This is done now.

  6. github-actions commented on Aug 29, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  7. locked as resolved and limited conversation to collaborators on Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

c: API breakBackwards-incompatible API changesframeworkflutter/packages/flutter repository. See also f: labels.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions