Skip to content

Flake in benchmarks_test.dart #34192

Closed

Description

@tvolkert

https://cirrus-ci.com/task/4703269759221760 (shard web_tests-linux)

00:18 +52 ~5 -1: compiling /tmp/flutter sdk/packages/flutter/test/scheduler/benchmarks_test.dart [E]                                                                                                   
  Failed to load "/tmp/flutter sdk/packages/flutter/test/scheduler/benchmarks_test.dart": Microtasks scheduled by 'handledBeginFrame' must be run before 'handleDrawFrame'.
  package:build_web_compilers/src/dev_compiler/dart_sdk.js 3979:11                                   throw
  org-dartlang-app:/test/scheduler/benchmarks_test.dart 30:7                                         handleDrawFrame
  package:flutter/src/scheduler/org-dartlang-app:/packages/flutter/src/scheduler/binding.dart 864:5  [_handleDrawFrame]
  package:build_web_compilers/src/dev_compiler/dart_sdk.js 129700:23                                 <fn>
  package:build_web_compilers/src/dev_compiler/dart_sdk.js 29096:14                                  _rootRunUnary
  package:build_web_compilers/src/dev_compiler/dart_sdk.js 28422:14                                  runUnary
  package:build_web_compilers/src/dev_compiler/dart_sdk.js 28341:14                                  runUnaryGuarded
  package:build_web_compilers/src/dev_compiler/dart_sdk.js 28375:34                                  <fn>

Activity

  1. tvolkert commented on Jun 10, 2019

    @tvolkert
    ContributorAuthor
  2. jonahwilliams commented on Jun 11, 2019

    @jonahwilliams
    Contributor

    cc @yjbanov, I wonder if this is a case where hooking into the browser event loop won't be as stable as what flutter engine does?

    If this flakes again on master I'll disable the test

  3. yjbanov commented on Jun 11, 2019

    @yjbanov
    Contributor

    This is a known issue that's been a non-issue so far. You found the first use-case for it. I filed #34245. I'd be OK with disabling this test for the Web, since we're not honoring the handledBeginFrame contract.

  4. github-actions commented on Aug 29, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  5. locked as resolved and limited conversation to collaborators on Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    c: flakeTests that sometimes, but not always, incorrectly pass

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions