Skip to content

Fix semantics offset rect for inline widgets #34433

Open

Description

@GaryQian

In Paragraph.assembleSemanticsNode, we are not properly including the offset of the placeholder rect in the semantics rect for the placeholder.

We should fix this, and fix that tests regarding this. See #34368

Activity

  1. self-assigned this
    on Jun 13, 2019
  2. added
    a: accessibilityAccessibility, e.g. VoiceOver or TalkBack. (aka a11y)
    a: typographyText rendering, possibly libtxt
    frameworkflutter/packages/flutter repository. See also f: labels.
    on Jun 13, 2019
  3. added this to the July 2019 milestone on Jun 13, 2019
  4. self-assigned this
    on Jun 13, 2019
  5. dnfield commented on Jun 20, 2019

    @dnfield
    Contributor

    The rects are good now, I think - but the ordering is off for traversal.

  6. removed their assignment
    on Jul 3, 2019
  7. modified the milestones: July 2019, on Aug 6, 2019
  8. modified the milestones: , on Aug 14, 2019
  9. added
    P2Important issues not at the top of the work list
    on May 29, 2020
  10. removed this from the milestone on Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work lista: accessibilityAccessibility, e.g. VoiceOver or TalkBack. (aka a11y)a: typographyText rendering, possibly libtxtframeworkflutter/packages/flutter repository. See also f: labels.team-frameworkOwned by Framework teamtriaged-frameworkTriaged by Framework team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions