Add iPhone XS to our device lab #34590

Activity

1. liyuqian

   added

   c: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.

   c: performanceRelates to speed or footprint issues (see "perf:" labels)Relates to speed or footprint issues (see "perf:" labels)

   on Jun 17, 2019
2. liyuqian commented on Jul 3, 2019

   

   liyuqian

   on Jul 3, 2019

   ContributorAuthor

   More actions

   This would also help #31086
3. liyuqian commented on Jul 3, 2019

   

   liyuqian

   on Jul 3, 2019

   ContributorAuthor

   More actions

   We've setup mac8 with iPhone X (currently in my desk instead of in the lab). I'll close the issue once we've done some successful performance benchmarks through #35556
4. liyuqian

   self-assigned this

   on Jul 3, 2019
5. MisterJimson commented on Jul 4, 2019

   

   MisterJimson

   on Jul 4, 2019

   More actions

   FYI I believe it's the XS, not the X, that has the higher sampling rate that causes performance issues. Just want to make sure you are setting up the correct device.
6. liyuqian

   changed the title [-]Add iPhone X to our device lab[/-] [+]Add iPhone XS to our device lab[/+] on Jul 6, 2019
7. liyuqian commented on Jul 6, 2019

   

   liyuqian

   on Jul 6, 2019

   ContributorAuthor

   More actions

   Luckily, we did buy the iPhone XS as Apple is no longer selling iPhone X on its website :) Edit the title of this issue to reflect that.
8. liyuqian

   added a commit that references this issue on Jul 8, 2019

   ios (iPhone6) and iPhone XS tiles_scroll_perf tests (#35556)

   ...

   34e18d3
9. johnsonmh

   added a commit that references this issue on Jul 30, 2019

   ios (iPhone6) and iPhone XS tiles_scroll_perf tests (flutter#35556)

   ...

   e48ede7
10. liyuqian commented on Jul 31, 2019

    

    liyuqian

    on Jul 31, 2019

    ContributorAuthor

    More actions

    Almost done. I only need to move the Mac Mini and iPhone XS from my desk to the actual lab.
11. liyuqian

    added this to the August 2019 milestone on Aug 7, 2019
12. liyuqian commented on Aug 8, 2019

    

    liyuqian

    on Aug 8, 2019

    ContributorAuthor

    More actions

    Our lab is currently running out of space. So the device will remain on my desk for a while. The test will keep running.
13. Hixie

    modified the milestones: August 2019, OverdueThis milestone has been deleted on Sep 3, 2019
14. liyuqian

    modified the milestones: OverdueThis milestone has been deleted, December 2019 on Sep 4, 2019
15. liyuqian commented on Sep 25, 2019

    

    liyuqian

    on Sep 25, 2019

    ContributorAuthor

    More actions

    Moved to the new device lab desk. Closing.
16. liyuqian

    closed this as completedon Sep 25, 2019
17. github-actions commented on Aug 27, 2021

    

    github-actionsbot

    on Aug 27, 2021

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
18. github-actions

    locked as resolved and limited conversation to collaborators on Aug 27, 2021