OverlayRoute.didPop shouldn't remove the overlays #370

Activity

1. Hixie

   added

   c: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.

   frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.

   on Nov 13, 2015
2. Hixie commented on Nov 13, 2015

   

   Hixie

   on Nov 13, 2015

   ContributorAuthor

   More actions

   TransitionRoute does this too, but even worse (didPop doesn't call super.didPop, then a completely unrelated _handleStatusChanged method calls super.didPop).
3. HansMuller commented on Nov 16, 2015

   

   HansMuller

   on Nov 16, 2015

   Contributor

   More actions

   I found the didPop() linkages in TransitionRoute difficult to follow and I definitely didn't improve matters in _BottomSheetRoute().

   Some of the tension comes from tests that want to call Navigator.pop() and then verify that their route is indeed gone. Similarly, the tests want to verify that showFoo().then( ) has removed whatever was being shown.
4. Hixie

   self-assigned this

   on Nov 17, 2015
5. Hixie

   closed this as completedon Nov 20, 2015
6. github-actions commented on Sep 7, 2021

   

   github-actionsbot

   on Sep 7, 2021

   More actions

   This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
7. github-actions

   locked as resolved and limited conversation to collaborators on Sep 7, 2021