Skip to content

Call GC before measuring the diff memory in our memory tests #37318

Open
Open
Call GC before measuring the diff memory in our memory tests#37318
Labels
P3Issues that are less important to the Flutter projectc: contributor-productivityTeam-specific productivity, code health, technical debt.c: performanceRelates to speed or footprint issues (see "perf:" labels)engineflutter/engine related. See also e: labels.perf: memoryPerformance issues related to memoryteam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

Description

@liyuqian
liyuqian
opened on Jul 31, 2019

To reduce false alarms like:

We may still measure the before-GC start/end memory to capture the GC performance. But we need to use after-GC start/end memory to calculate the diff memory.

Activity

  1. liyuqian
    added
    c: contributor-productivityTeam-specific productivity, code health, technical debt.
    c: performanceRelates to speed or footprint issues (see "perf:" labels)
    on Jul 31, 2019

  2. liyuqian commented on Jul 31, 2019

    @liyuqian
    liyuqian
    on Jul 31, 2019
    ContributorAuthor

    CC @cobblest to see if this could help DevTools on memory

  3. liyuqian
    added
    perf: memoryPerformance issues related to memory
    on Dec 2, 2019
  4. VladyslavBondarenko
    added
    engineflutter/engine related. See also e: labels.
    on Jan 14, 2020
  5. chinmaygarde
    added
    P6
    on Jun 15, 2020
  6. darshankawar
    added
    passed first triage
    on Oct 26, 2020
  7. flutter-triage-bot
    added
    P3Issues that are less important to the Flutter project
    and removed
    P6
    on Jun 28, 2023
  8. flutter-triage-bot
    added
    team-engineOwned by Engine team
    triaged-engineTriaged by Engine team
    on Jul 8, 2023
  9. Hixie
    removed
    passed first triage
    on Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projectc: contributor-productivityTeam-specific productivity, code health, technical debt.c: performanceRelates to speed or footprint issues (see "perf:" labels)engineflutter/engine related. See also e: labels.perf: memoryPerformance issues related to memoryteam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions