Flutter does not receive key up events when cmd key is pressed (macOS) #38076

Activity

1. shyndman commented on Aug 10, 2019

   

   shyndman

   on Aug 10, 2019

   ContributorAuthor

   More actions

   cc @stuartmorgan
2. stuartmorgan-g

   added

   a: desktopRunning on desktopRunning on desktop

   engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.

   platform-macosBuilding on or for macOS specificallyBuilding on or for macOS specifically

   on Aug 12, 2019
3. shyndman commented on Aug 12, 2019

   

   shyndman

   on Aug 12, 2019

   ContributorAuthor

   More actions

   Any thoughts on approach Stuart? I had the thought that subclassing NSApplication might make integration into existing projects more difficult, but that could be outweighed by the value of dealing with the raw event stream.

   Also, is the preference to do this work in Objective-C?
4. stuartmorgan-g commented on Aug 12, 2019

   

   stuartmorgan-g

   on Aug 12, 2019

   Contributor

   More actions

   Any thoughts on approach Stuart?

   No, I haven't spent any time investigating this issue. Labelling an issue isn't an indication that I've spent time investigating it.

   Also, is the preference to do this work in Objective-C?

   Well, "this work" hasn't been clearly defined; the answer to that question depends on whether the work in in the framework or the template.
5. stuartmorgan-g

   added this to the GoalsThis milestone has been deleted milestone on Aug 13, 2019
6. shyndman commented on Aug 19, 2019

   

   shyndman

   on Aug 19, 2019

   Last edited by shyndman

   ContributorAuthor

   More actions

   Just a quick update here. We managed to get around this with my suggestion above. I'm not sure if it's the best way to go about it, but might be useful when you choose to implement.

   @objc(MyApplication)
   class MyApplication : NSApplication {
     override func sendEvent(_ event: NSEvent) {
       if event.type == .keyUp && event.modifierFlags.intersection(.command).rawValue != 0 {
         self.keyWindow?.sendEvent(event)
       } else {
         super.sendEvent(event)
       }
     }
   }

   Before going down this path, we first tried hooking into ExampleWindow's sendEvent (which seems less intrusive), but the keyUp never arrives.
7. hpoul commented on Aug 30, 2019

   

   hpoul

   on Aug 30, 2019

   Last edited by hpoul

   Contributor

   More actions

   I'm experiencing a similar issue of "sticky" keys in RawKeyboard.instance.keysPressed
   when I have a key down for shift+X but then let go of the shift before releasing x i'll have a sticky X which never disappears and hence the Shortcuts widget & co won't work at all.
   Should I open a separate issue for this? Imho the sticky key problem seems very related, especially i'm not sure how this could work in a desktop environment where it's not unusual to switch apps or otherwise lose focus before receiving a matching keyup event?

       RawKeyboard.instance.addListener(_debugEvent);
   
     void _debugEvent(RawKeyEvent ev) {
       final keys = RawKeyboard.instance.keysPressed.map((k) => '${k.keyId} (${k.keyLabel})');
       _logger.fine('Got key event. $keys');
     }

   Got key event. (65 (A))           //// keep shift + A pressed
   Got key event. (65 (A))
   Got key event. (65 (A), 97 (a))   /// released shift
   Got key event. (65 (A), 97 (a))
   Got key event. (65 (A))           /// released A
   

   👍React with 👍1Reacted by Santhosh Kumar
8. shyndman commented on Sep 4, 2019

   

   shyndman

   on Sep 4, 2019

   Last edited by shyndman

   ContributorAuthor

   More actions

   Hi @hpoul,

   This narrows down some problems we've been seeing, so thanks. That said, it's different. It would make sense to file a separate issue.
9. gspencergoog commented on Oct 18, 2019

   

   gspencergoog

   on Oct 18, 2019

   Contributor

   More actions

   /cc @franciscojma86

   This is a result of macOS engine not monitoring the flagsChanged message. We'll need to keep track of the modifier state and send additional key events when modifiers are pressed and released, similar to this example for CapsLock: https://developer.apple.com/library/archive/qa/qa1519/_index.html
10. franciscojma86

    self-assigned this

    on Oct 21, 2019
11. franciscojma86 commented on Oct 23, 2019

    

    franciscojma86

    on Oct 23, 2019

    Contributor

    More actions

    Landed, @shyndman LMK if you see any issues, thanks for filing!
12. franciscojma86

    closed this as completedon Oct 23, 2019
13. github-actions commented on Aug 13, 2021

    

    github-actionsbot

    on Aug 13, 2021

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
14. github-actions

    locked as resolved and limited conversation to collaborators on Aug 13, 2021