Skip to content

Local engine workflow for iOS profile/release mode is broken. #38933

Closed

Description

@chinmaygarde

The local engine workflow looks for gen_snapshot_armv7 or gen_snapshot_arm64. This is now because the gen_snapshot is no longer a multi-arch lipo-ed binary.

Activity

  1. added
    c: regressionIt was better in the past than it is now
    engineflutter/engine related. See also e: labels.
    on Aug 21, 2019
  2. chinmaygarde commented on Aug 21, 2019

    @chinmaygarde
    ContributorAuthor
  3. changed the title [-]Local engine workflow for iOS release mode is broken.[/-] [+]Local engine workflow for iOS profile/release mode is broken.[/+] on Aug 21, 2019
  4. chinmaygarde commented on Aug 21, 2019

    @chinmaygarde
    ContributorAuthor

    Temporary workaround is to symlink gen_snapshot_armv7 or gen_snapshot_arm64 to gen_snapshot while developing locally.

  5. liyuqian commented on Oct 9, 2019

    @liyuqian
    Contributor

    Is there anyone working on this @chinmaygarde ? @LongCatIsLooong encountered this issue today again.

  6. chinmaygarde commented on Oct 9, 2019

    @chinmaygarde
    ContributorAuthor

    No. This has not been assigned to anyone.

  7. liyuqian commented on Oct 9, 2019

    @liyuqian
    Contributor

    What would the fix look like? Modify some BUILD.gn file to do symlink automatically?

  8. chinmaygarde commented on Oct 9, 2019

    @chinmaygarde
    ContributorAuthor

    What would the fix look like?

    Update the flutter tool to look for the artifact at the correct location based on target architecture.

  9. xster commented on Nov 8, 2019

    @xster
    Member

    I don't know the background for why the split was there in the first place. Sounds like we just want to remove

    snapshotterPath += '_' + getNameForDarwinArch(darwinArch);

  10. added
    toolAffects the "flutter" command-line tool. See also t: labels.
    on Dec 17, 2019
  11. iskakaushik commented on Apr 14, 2020

    @iskakaushik
    Contributor

    +1 I hit this today as well.

  12. chinmaygarde commented on Jun 11, 2020

    @chinmaygarde
    ContributorAuthor

    Triage: @jmagman, it seems like the current behavior is intentional as fixing this for local engine workflows would cause issues for end users because of Xcode caching certain build variable. Is that an accurate assessment of the challenges in resolving this? I am assigning a low priority for this accordingly. If you think both workflows can be adequately served, please revise the priority. Thanks.

  13. 3 remaining items

  14. added
    a: qualityA truly polished experience
    c: contributor-productivityTeam-specific productivity, code health, technical debt.
    and removed
    c: regressionIt was better in the past than it is now
    on Jul 15, 2020
  15. xster commented on Aug 14, 2020

    @xster
    Member

    FWIW many of our customers build their own local engines too. But I don't think they're blocked either since this is a small workaround.

  16. Vadaski commented on Sep 18, 2020

    @Vadaski
    Contributor

    A easy way to solve this problem is copy gen_snapshot and rename the copy one's name to gen_snapshot_arm64.
    It works for me.

  17. jmagman commented on Dec 23, 2020

    @jmagman
    Member

    Hm I just hit this with a ios_release_unopt on engine top of tree.

        Oops; flutter has exited unexpectedly: "Invalid argument(s): Cannot find executable for /Users/magder/Projects/engine/src/out/ios_release_unopt/clang_x64/gen_snapshot_arm64.".
    
  18. AlBlanc commented on Apr 23, 2021

    @AlBlanc

    I just has the same with ios_release

  19. github-actions commented on Sep 11, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  20. locked as resolved and limited conversation to collaborators on Sep 11, 2021
  21. added
    P3Issues that are less important to the Flutter project
    and removed on Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projecta: qualityA truly polished experiencec: contributor-productivityTeam-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.platform-iosiOS applications specificallytoolAffects the "flutter" command-line tool. See also t: labels.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions