Repository navigation
Engine roll causing observatory connection timeouts on 32-bit iPhones #40114
Description
I reverted two engine rolls in #40112 because the were causing failures in devicelab tests that were failing with timeouts trying to connect to the observatory: flutter_gallery_ios32__transition_perf and flutter_gallery_ios32__start_up.
I HAVE STOPPED THE ENGINE ROLL, so someone needs to restart it once this is resolved.
Specifically, they started failing when af07bb5 was committed, which includes a Dart roll that is probably suspect:
2019-09-06 [email protected] Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits)
Here is a sample log output of one of the tests (both are similar):
2019-09-09T14:09:01.547976: stdout: [ +40 ms] (lldb) run
2019-09-09T14:09:03.005319: stdout: [+1457 ms] success
stdout: [ ] (lldb) safequit
2019-09-09T14:09:03.132474: stdout: [ +125 ms] Process 248 detached
2019-09-09T14:09:03.159828: stdout: [ +28 ms] Application launched on the device. Waiting for observatory port.
2019-09-09T14:21:27.297237: Task timed out in framework.dart after 0:15:00.000000.
Cleaning up after task...
2019-09-09T14:21:28.310369: Force-quitting process:
command : bin/flutter run --verbose --profile --trace-startup -d [device id redacted]
started : 2019-09-09 14:06:29.482349
pid : 12227
2019-09-09T14:21:28.318085: "bin/flutter" exit code: -15
2019-09-09T14:21:29.329736: Task execution finished
Task failed with the following reason:
Timeout waiting for task process to exit: Future not completed
Activity
gspencergoog commentedon Sep 9, 2019
Note that reverting this also fixed a problem in
flutter_gallery__back_button_memory. It's unclear if this engine roll is the culprit there, since it seemed to pass on the initial commit (but failed every build thereafter until I reverted this). And it's also not on 32-bit iOS, so there may be concurrent unconnected problems here.blasten commentedon Sep 10, 2019
Should we still keep the
TODAYlabel @gspencergoog ?tvolkert commentedon Sep 10, 2019
Yes, this should stay TODAY, as the engine auto-roller is blocked on reverting the culprit in the engine or Dart SDK.
mklim commentedon Sep 10, 2019
mklim commentedon Sep 11, 2019
Revert engine roll (#40112)
Roll engine 7ea9884..50bdbd7 (3 commits) (#40017)
c9ea4db [flutter_runner] Refactor our build rules to make them more i…
mklim commentedon Sep 11, 2019
Okay, I can reliably reproduce this now. It has to do with profile mode specifically. Just
flutter runor building the engine in debug mode isn't enough to repro. Butflutter run --profilewill briefly launch the app, the app will crash, and then the tool will hang.The log I mentioned above doesn't appear with this. I think it was just a one-off local build error.
14 remaining items
aam commentedon Sep 12, 2019
Sent out https://dart-review.googlesource.com/c/sdk/+/116883 with revert in dart sdk, so dart-to-engine roll can be resumed
Revert Reland '[vm/ffi] Implement FFI callbacks on AOT for ELF and As…
sjindel-google commentedon Sep 12, 2019
@mklim What app did you run to reproduce the crash? Also, did it happen on 64-bit iOS or only 32-bit?
aam commentedon Sep 12, 2019
@sjindel-google I used flutter gallery (in profile/release mode). ios 32-bit was the only affected as far as I know.
mklim commentedon Sep 12, 2019
@sjindel-google my testing was the same as @aam's.
mklim commentedon Sep 12, 2019
I've resumed the dart to engine roller since the revert landed in dart-lang/sdk@0c481a1. I think it's safe to consider this fixed now.
Roll engine from 7ea9884..3c6383f (77 commits 🔥) (#40372)
[vm] Support testing assembly snapshots for ARM.
[vm] Switch vm-kernel-precomp-mac-debug-simarm_x64 to vm-kernel-preco…
Roll engine from 7ea9884..3c6383f (77 commits 🔥) (flutter#40372)
Revert Reland '[vm/ffi] Implement FFI callbacks on AOT for ELF and As…
github-actions commentedon Aug 28, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.