Skip to content

Rename AnimatedSize to RawAnimatedSize and then create a new AnimatedSize to wrap RawAnimatedSize #40475

Closed

Description

@efortuna

Use case

AnimatedSize bucks the naming convention of "all AnimatedFoo widgets were implicitly animated" -- it takes a vsync parameter.

Proposal

I discussed this with Ian on Discord. He pointed that this is because AnimatedSize is implemented as a render object widget. We should probably rename it RawAnimatedSize and then create a stateful widget called AnimatedSize that wraps it, and knows how to create its own ticker provider.

Activity

  1. added
    frameworkflutter/packages/flutter repository. See also f: labels.
    on Sep 23, 2019
  2. goderbauer commented on Jan 17, 2023

    @goderbauer
    Member

    AnimatedSize no longer takes a vsync (the param is deprecated and ignored; will be removed in a future version of flutter).

  3. github-actions commented on Mar 4, 2023

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  4. locked as resolved and limited conversation to collaborators on Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    a: animationAnimation APIsc: API breakBackwards-incompatible API changesc: proposalA detailed proposal for a change to Flutterframeworkflutter/packages/flutter repository. See also f: labels.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions