Skip to content

Redesign snackbar API to not use routes #432

Closed

Description

@Hixie

I think snack bars should be a feature of a Scaffold. They probably shouldn't use routes at all.

According to the specs -- https://www.google.com/design/spec/components/snackbars-toasts.html#snackbars-toasts-specs -- they should not time out while another route (e.g. a dialog) is over them, they should reset their timeout when their parent route resumes being the current route, they should be displayed consecutively in time, etc.

Activity

  1. added
    c: new featureNothing broken; request for a new capability
    c: contributor-productivityTeam-specific productivity, code health, technical debt.
    frameworkflutter/packages/flutter repository. See also f: labels.
    on Nov 17, 2015
  2. added this to the milestone on Nov 17, 2015
  3. HansMuller commented on Nov 17, 2015

    @HansMuller
    Contributor

    This sounds correct to me. Perhaps non-modal bottom sheets should also just be a scaffold feature?

  4. Hixie commented on Nov 17, 2015

    @Hixie
    ContributorAuthor

    Well, they need a StateRoute so that they can react to the back button (I don't think snack bars should react to the back button). But beyond that, maybe.

  5. self-assigned this
    on Nov 17, 2015
  6. github-actions commented on Aug 17, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  7. locked as resolved and limited conversation to collaborators on Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

c: contributor-productivityTeam-specific productivity, code health, technical debt.c: new featureNothing broken; request for a new capabilityframeworkflutter/packages/flutter repository. See also f: labels.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions