Migrate android_semantics_testing and android_views to the v2 embedding

There are a few cases where access to FlutterView is currently needed.

flutterView.getAccessibilityNodeProvider() in
https://github.com/flutter/flutter/blob/master/dev/integration_tests/android_semantics_testing/android/app/src/main/java/com/yourcompany/platforminteraction/MainActivity.java#L44
Full Flutter view. https://github.com/flutter/flutter/blob/master/dev/integration_tests/android_views/android/app/src/main/java/io/flutter/integration/androidviews/MainActivity.java#L39

These two tests are needed for #33884

@matthew-carroll

@matthew-carroll Let me know what you have in mind, so I can update these tests accordingly.

For the platform views touch verification, let's try using the root View of the Activity instead of FlutterView. To do this, obtain the root View as follows:

View rootView = findViewById(0x01020002);

Then replace the existing FlutterView references with this rootView.

For the accessibility test, I think we can use the following code to find the FlutterView, allowing us to avoid exposing it publicly.

  AccessibilityNodeProvider getFlutterAccessibilityNodeProvider() {
    FlutterView flutterView = findFlutterView();
    return flutterView.getAccessibilityNodeProvider();
  }

  FlutterView findFlutterView() {
    View rootView = findViewById(android.R.id.content);
    List<View> viewsToSearch = new ArrayList<>();
    viewsToSearch.add(rootView);
    FlutterView flutterView = null;
    while (flutterView == null && viewsToSearch.size() > 0) {
      View nextView = viewsToSearch.remove(0);
      if (nextView instanceof FlutterView) {
        flutterView = (FlutterView) nextView;
      } else {
        if (nextView instanceof ViewGroup) {
          ViewGroup parentView = (ViewGroup) nextView;
          for (int i = 0; i < parentView.getChildCount(); ++i) {
            viewsToSearch.add(parentView.getChildAt(i));
          }
        }
      }
    }
    return flutterView;
  }

The reason that I think this is appropriate is because I think this test is the result of a lack of infrastructure. We should be able to run accessibility tests from an e2e standpoint, but it seems that our infra doesn't facilitate that. So this test is inherently about implementation details. Therefore, I think it should be OK to act with the knowledge that within FlutterActivity there is a FlutterView.

Anything we need to do here? Is this not the same issue as exposing the view to the platform view factory?

@xster

@xster there were 2 specific uses that @blasten found in the device lab tests. I posted workarounds above. I don't think we need to make any changes to the embedding API for this, but I left the ticket open to be closed by @blasten whenever he is able to try these workarounds in the tests.

@blasten

@blasten when you get a chance, can you take a look at this ticket and see if we can close it as per the last comment above?

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.

Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.

Looks like integration_tests/android_views was migrated to v2 embedding but integration_tests/android_semantics_testing hasn't yet.

Dropping the priority to reflect the fact that this has gone untouched for ~3 years

Navigation Menu

Repository navigation

Migrate android_semantics_testing and android_views to the v2 embedding #43220

18 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Migrate android_semantics_testing and android_views to the v2 embedding #43220

Description

Activity

blasten commented on Oct 21, 2019

matthew-carroll commented on Oct 23, 2019

matthew-carroll commented on Oct 23, 2019

xster commented on Nov 5, 2019

matthew-carroll commented on Nov 5, 2019

matthew-carroll commented on Jan 13, 2020

18 remaining items

pedromassangocode commented on Nov 27, 2020

xster commented on Nov 30, 2020

gmackall commented on Sep 28, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions