Skip to content

Remove RenderSliverFillViewport since it has no widget #44612

Closed

Description

@Hixie

We seem to have deprecated the render object without leaving a widget in place to use it. We should just remove it.

History: #37024

Activity

  1. added
    c: contributor-productivityTeam-specific productivity, code health, technical debt.
    frameworkflutter/packages/flutter repository. See also f: labels.
    on Nov 11, 2019
  2. added this to the milestone on Nov 11, 2019
  3. Hixie commented on Nov 11, 2019

    @Hixie
    ContributorAuthor
  4. goderbauer commented on Nov 11, 2019

    @goderbauer
    Member

    Yes, that sounds good.

  5. Hixie commented on Nov 11, 2019

    @Hixie
    ContributorAuthor

    (We may want to make sure #39060 is solved first.)

  6. added
    P2Important issues not at the top of the work list
    on May 29, 2020
  7. removed this from the milestone on Aug 17, 2020
  8. thecalamiity commented on Aug 25, 2020

    @thecalamiity
    Contributor

    @Hixie I believe the PR was reverted, which means RenderSliverFillViewport is not deprecated anymore. Right?

  9. Hixie commented on Aug 25, 2020

    @Hixie
    ContributorAuthor

    RenderSliverFillViewport is not currently marked deprecated. It seems weird that we don't have a widget for it though.

  10. goderbauer commented on Aug 25, 2020

    @goderbauer
    Member

    It also appears to have a widget SliverFillViewport, which uses the RenderObject internally. I am going to close this one.

  11. LongCatIsLooong commented on Aug 25, 2020

    @LongCatIsLooong
    Contributor

    My first attempt got reverted because a benchmark regressed: #39060. Had to take a different approach that keeps using RenderSliverFillViewport

  12. github-actions commented on Aug 13, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  13. locked as resolved and limited conversation to collaborators on Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.frameworkflutter/packages/flutter repository. See also f: labels.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions