Skip to content

New Android embedding is only enabled on master #45453

Closed
#46040
Closed
New Android embedding is only enabled on master#45453
#46040
Assignees
blasten
Labels
a: existing-appsIntegration with existing apps via the add-to-app flowplatform-androidAndroid applications specifically

Description

@tvolkert
tvolkert
opened on Nov 23, 2019

hostonly_devicelab_tests are failing only in non-master branches on Cirrus with the following error.

[module_test] [STDOUT] stderr: /private/var/folders/sy/2x5qvs0n4lg18fry9jz4y21m0000gn/T/flutter_module_test.vOxl3v/hello_host_app/app/src/main/java/io/flutter/add2app/MainActivity.java:11: error: incompatible types: FlutterEngine cannot be converted to PluginRegistry
[module_test] [STDOUT] stderr:     GeneratedPluginRegistrant.registerWith(flutterEngine);
[module_test] [STDOUT] stderr:

For example: https://cirrus-ci.com/task/4684340952301568

Activity

  1. tvolkert
    added
    c: contributor-productivityTeam-specific productivity, code health, technical debt.
    on Nov 23, 2019

  2. xster commented on Nov 23, 2019

    @xster
    xster
    on Nov 23, 2019
    Member

    cc @blasten, not sure if there's anything to do there since the state of the code at tip of tree is very different now, but it looks like this registration is using a new embedding with old plugins directly without shim

  3. tvolkert
    added a commit that references this issue on Nov 25, 2019

    Disable tests that fail on non-master branches from running on those …

    bae92c3

  4. tvolkert commented on Dec 3, 2019

    @tvolkert
    tvolkert
    on Dec 3, 2019
    ContributorAuthor

    This is failing on beta channel with v1.12.13+hotfix.1, which is very new.

    https://cirrus-ci.com/task/6300811973361664

    @blasten @matthew-carroll thoughts?

  5. matthew-carroll commented on Dec 3, 2019

    @matthew-carroll
    matthew-carroll
    on Dec 3, 2019
    Contributor

    The following leads me to believe that the flutter tool is generating the wrong version of the plugin registrant:

    [module_test] [STDOUT] stderr: C:\Users\ContainerAdministrator\AppData\Local\Temp\flutter_module_test.884c5db6-1601-11ea-aad5-8bd5e2fead93\hello\.android\Flutter\src\main\java\io\flutter\facade\Flutter.java:98: error: incompatible types: FlutterPluginRegistry cannot be converted to FlutterEngine
[module_test] [STDOUT] stderr:         GeneratedPluginRegistrant.registerWith(flutterView.getPluginRegistry());
[module_test] [STDOUT] stderr:                                                                             ^

    Given that the project is referencing a flutterView, I think it should be using the old registrant version, but it appears to be using the new registrant version.

    @blasten

  6. blasten commented on Dec 3, 2019

    @blasten
    blasten
    on Dec 3, 2019

    The Android embedding is enabled on the master branch only ☹️.
    https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/features.dart#L148-L156

  7. matthew-carroll commented on Dec 4, 2019

    @matthew-carroll
    matthew-carroll
    on Dec 4, 2019
    Contributor

    @blasten can you patch that to allow us to roll to other channels?

  8. tvolkert commented on Dec 4, 2019

    @tvolkert
    tvolkert
    on Dec 4, 2019
    ContributorAuthor

    That would explain it!

    That's definitely something we should fix ASAP since we want the new embedding enabled in our next stable release. Marking as a release blocker, which means I'll gladly accept cherry-pick of tested PRs 🙂

  9. tvolkert
    added
    a: existing-appsIntegration with existing apps via the add-to-app flow
    RELEASE BLOCKER
    platform-androidAndroid applications specifically
    and removed
    c: contributor-productivityTeam-specific productivity, code health, technical debt.
    on Dec 4, 2019
  10. tvolkert
    changed the title [-]hostonly_devicelab_tests failing on dev and beta branches[/-] [+]New Android embedding is only enabled on master[/+] on Dec 4, 2019
  11. tvolkert
    assigned
    blasten
    on Dec 4, 2019
  12. blasten
    closed this as completedin #46040on Dec 4, 2019
  13. tvolkert
    added a commit that references this issue on Dec 4, 2019

    Re-enable hostonly tests on non-master branches (#46037)

    4c95bbd

  14. tvolkert commented on Dec 4, 2019

    @tvolkert
    tvolkert
    on Dec 4, 2019
    ContributorAuthor

    This has been cherry-picked in v1.12.13+hotfix.2, so removing the release blocker label.

  15. tvolkert
    removed
    RELEASE BLOCKER
    on Dec 4, 2019

  16. github-actions commented on Aug 25, 2021

    @github-actions
    github-actionsbot
    on Aug 25, 2021

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  17. github-actions
    locked as resolved and limited conversation to collaborators on Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

a: existing-appsIntegration with existing apps via the add-to-app flowplatform-androidAndroid applications specifically

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions