You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@Hixie I'm looking at this issue. I doesn't seem flutter run is ignoring the entrypoint. As you noted, it's very likely that this issue is caused by #45307 (comment).
The issue is that the test relies on the flutter run stdout. In verbose mode, flutter run stdout also includes the device's stdout (from the device logger) which used to skip logs that were older than the flutter run command invocation. In my change, I forwarded all the device logs that have the "flutter" tag, so that isn't what the test expects.
I just confirmed that flutter run xxx.dart worked for me too. Sorry for giving you the wrong suggestion because I tried to modify the running target in microbenchmarks.dart and saw the result of dart bin/run.dart -t microbenchmarks to be not changed. Now I understand that the result doesn't change because we're always reading the old log...
Can we return to the previous behaviour? We didn't have the old behaviour just randomly, it was very much intentional that flutter logs and flutter run not give you old logs. :-)
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
Activity
Hixie commentedon Nov 27, 2019
@liyuqian suggests this is because
flutter run xxx.dartis ignoring thexxx.dart. If this is true then this is a stop-ship regression.blasten commentedon Nov 27, 2019
@Hixie I'm looking at this issue. I doesn't seem
flutter runis ignoring the entrypoint. As you noted, it's very likely that this issue is caused by #45307 (comment).xster commentedon Nov 27, 2019
flutter run -t xxxseems to work for me on head as well`blasten commentedon Nov 27, 2019
The issue is that the test relies on the
flutter runstdout. In verbose mode,flutter runstdout also includes the device's stdout (from the device logger) which used to skip logs that were older than theflutter runcommand invocation. In my change, I forwarded all the device logs that have the "flutter" tag, so that isn't what the test expects.liyuqian commentedon Nov 27, 2019
I just confirmed that
flutter run xxx.dartworked for me too. Sorry for giving you the wrong suggestion because I tried to modify the running target in microbenchmarks.dart and saw the result ofdart bin/run.dart -t microbenchmarksto be not changed. Now I understand that the result doesn't change because we're always reading the old log...Hixie commentedon Nov 27, 2019
Ok, good. Removing panic markers.
Can we return to the previous behaviour? We didn't have the old behaviour just randomly, it was very much intentional that
flutter logsandflutter runnot give you old logs. :-)blasten commentedon Nov 28, 2019
The microbenchmarks are back!
Hixie commentedon Nov 28, 2019
Yay! Thanks for fixing this on your day off! Please definitely don't feel you must do that, but it is appreciated! :-)
github-actions commentedon Aug 13, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.