showCupertinoDialog should support barrierDismissible #45744

Activity

1. mehmetf

   added

   customer: googleVarious Google teamsVarious Google teams

   p: cupertino_uicupertino_ui package in flutter/packagescupertino_ui package in flutter/packages

   on Nov 28, 2019
2. LongCatIsLooong

   closed this as completedon Nov 28, 2019
3. LongCatIsLooong

   reopened this on Nov 28, 2019
4. HansMuller

   added

   frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.

   on Dec 4, 2019
5. alectogeek commented on Jan 2, 2020

   

   alectogeek

   on Jan 2, 2020

   More actions

   We realy need this feature!
6. LongCatIsLooong commented on Jan 2, 2020

   

   LongCatIsLooong

   on Jan 2, 2020

   Contributor

   More actions

   I couldn't find anything that says this is not allowed, but from https://developer.apple.com/design/human-interface-guidelines/ios/views/alerts/ it shouldn't be encouraged either, as barrierDismissible = true makes it a lot easier for users to dismiss something important by mistake:

   Minimize alerts. Alerts disrupt the user experience and should only be used in important situations like confirming purchases and destructive actions (such as deletions), or notifying people about problems. The infrequency of alerts helps ensure that people take them seriously. Ensure that each alert offers critical information and useful choices.

   Sounds reasonable to add the parameter but set the default to false.
7. LongCatIsLooong

   added

   easy fix

   on Jan 2, 2020
8. tottomotto commented on Jan 29, 2020

   

   tottomotto

   on Jan 29, 2020

   Last edited by tottomotto

   Contributor

   More actions

   @xster,can you please share your thoughts on this.
   I Implemented the change (defaulting to false) and I can make a PR if it's ok.
9. xster commented on Feb 4, 2020

   

   xster

   on Feb 4, 2020

   Member

   More actions

   Making it configurable (but defaulted to false) seems reasonable to me.
10. fluttergithubbot

    closed this as completedin #50915on Apr 29, 2020
11. github-actions commented on Aug 21, 2021

    

    github-actionsbot

    on Aug 21, 2021

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
12. github-actions

    locked as resolved and limited conversation to collaborators on Aug 21, 2021