Skip to content

We should derive the system chrome ui overlay style from a layer #4630

Description

@tvolkert

On iOS, using AppBarBehavior.scroll can cause the status bar overlay to go from being painted over a dark background to over a light one (or vice versa). Doing so without calling SystemChrome.setSystemUIOverlayStyle() will mean that the status bar will be hard to see in one of the app bar states (either visible or scrolled off).

e.g. in the Flutter Gallery's contacts demo:

App Bar visible

scrolled-up

App Bar scrolled away

scrolled-down

Activity

  1. added
    platform-iosiOS applications specifically
    p: material_uimaterial_ui package in flutter/packages
    customer: galleryRelating to flutter/gallery repository. Please transfer non-framework issues there.
    on Jun 20, 2016
  2. tvolkert commented on Jun 20, 2016

    @tvolkert
    ContributorAuthor

    /cc @HansMuller @Hixie maybe we should have have the option of showing a shadow in the app bar space... this is what the Google Photos app does in the single-photo page.

  3. HansMuller commented on Jun 20, 2016

    @HansMuller
    Contributor

    The contacts demo already adds a shadow. The shadow doesn't help in this case because it's being added to the flexibleSpaceBar which fades out when the app bar get smaller than its toolbar.

    We can't just make the shadow (the DecoratedBox with a gradient child, see contacts_demo.dart) the AppBar's parent because the Scaffold expects it's appBar to be an AppBar so that it can change its elevation and etc.

    We could make the AppBar render the shadow itself with a flag for turning that on and off. Not super fluttery but probably the simplest tack.

  4. Hixie commented on Jun 20, 2016

    @Hixie
    Contributor

    This only matters on iOS, right?

  5. Hixie commented on Jun 20, 2016

    @Hixie
    Contributor

    (#4430 will make adding the shade effect trivial.)

  6. tvolkert commented on Jun 20, 2016

    @tvolkert
    ContributorAuthor

    Yeah it only matters on iOS

  7. modified the milestone: on Aug 1, 2016
  8. added
    frameworkflutter/packages/flutter repository. See also f: labels.
    on Sep 12, 2016
  9. self-assigned this
    on Sep 23, 2016
  10. modified the milestones: 2: Make Early Adopters happy, on Jan 30, 2017
  11. 16 remaining items

  12. added this to the bucket5 milestone on May 29, 2018
  13. tvolkert commented on Jun 6, 2018

    @tvolkert
    ContributorAuthor

    @jonahwilliams any update on this?

  14. jonahwilliams commented on Jun 6, 2018

    @jonahwilliams
    Contributor

    @tvolkert Took a break to work on android/buildroot issues but I'm back to working on it this week.

  15. modified the milestones: bucket5, on Jun 19, 2018
  16. modified the milestones: , bucket6 on Jun 19, 2018
  17. mehmetf commented on Jun 20, 2018

    @mehmetf
    Contributor

    @jonahwilliams Please give an update. This is actually a blocker for mulligan.

  18. jonahwilliams commented on Jun 20, 2018

    @jonahwilliams
    Contributor

    PR is done waiting for LGTM and Green to land

  19. jonahwilliams commented on Jun 25, 2018

    @jonahwilliams
    Contributor

    Fixed by #17672

  20. github-actions commented on Sep 2, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  21. locked as resolved and limited conversation to collaborators on Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

customer: galleryRelating to flutter/gallery repository. Please transfer non-framework issues there.customer: mulligan (g3)f: scrollingViewports, list views, slivers, etc.frameworkflutter/packages/flutter repository. See also f: labels.p: material_uimaterial_ui package in flutter/packagesplatform-iosiOS applications specifically

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions