Skip to content

[package_info] Add web implementation #46609

Closed

Description

@provokateurin
No description provided.

Activity

  1. harryterkelsen commented on Dec 9, 2019

    @harryterkelsen
    Contributor

    What would you like the web implementation of package_info to do? I can't really think of natural web implementations of these: https://pub.dev/documentation/package_info/latest/package_info/PackageInfo-class.html

  2. added
    waiting for responseThe Flutter team cannot make further progress on this issue until the original reporter responds
    on Dec 9, 2019
  3. provokateurin commented on Dec 9, 2019

    @provokateurin
    Author

    The most important feature is the version and the build number of the app. Maybe the version and build number could be inserted at compile time and then be read by the plugin? All the other features don't matter for me, but should be supported in some way for completeness.

  4. removed
    waiting for responseThe Flutter team cannot make further progress on this issue until the original reporter responds
    on Dec 9, 2019
  5. added this to the milestone on Dec 12, 2019
  6. jj10133 commented on Apr 27, 2020

    @jj10133

    Hi, I would like to ask if anyone could give me some idea on how to integrate the web part?? Like i don't no where to begin from.

  7. topilski commented on May 3, 2020

    @topilski

    Any updates?

  8. deakjahn commented on May 15, 2020

    @deakjahn
    Contributor

    @hterkelsen This one is easy to answer:

    appName - the name of the application that's placed into the Index.html TITLE tag. Maybe the description, that can be discussed, because:

    packageName - might be the name entry from the pubspec.yaml instead.

    version - pubspec.yaml version before the plus

    buildNumber - pubspec.yaml version after the plus

  9. jj10133 commented on May 16, 2020

    @jj10133

    @hterkelsen I would like to ask you that within this plugin the macos implementation didn't add the package_info into another directory of it so do i leave it or follow the instruction from your medium article

  10. added
    P2Important issues not at the top of the work list
    on May 29, 2020
  11. added
    P3Issues that are less important to the Flutter project
    on Jun 16, 2020
  12. 20 remaining items

  13. topilski commented on Oct 13, 2020

    @topilski

    Yes works, thank you!

  14. balvinderz commented on Oct 13, 2020

    @balvinderz
    Contributor

    @ditman I think this can be closed now.

  15. ditman commented on Oct 13, 2020

    @ditman
    Member

    It can! Thanks @balvinderz!

    Take a look at package_info_plus, it supports web!

    Closing this as done!

  16. Grohden commented on Oct 23, 2020

    @Grohden

    So... package_info_plus doesn't work really well for web - at least for me it wasn't finding version.json.

    I think that the best approach is generating static info at build time from pubspec.yaml and there's already a package for that! https://pub.dev/packages/build_pubspec

    The package generates pubspec.yaml dart code at build time, so we're able to retrieve those infos and use them without all of those async await calls.

    Of course, these infos have to be manipulated properly (eg: split version by + to get build and version name) and they also don't reflect the real platform files (eg: if you change something directly on platform files that are not generated from pubspec.yaml), but despite these problems I think that its a good alternative.

    Note: the only prop I don't see being generated here is the appName, but at least for me, it's not needed - and also probably can be added in pubspec + generated

  17. balvinderz commented on Oct 23, 2020

    @balvinderz
    Contributor

    @Grohden are you on latest master or dev branch?

  18. Grohden commented on Oct 23, 2020

    @Grohden

    @balvinderz flutter?

    Flutter 1.22.0 • channel beta • https://github.com/flutter/flutter.git
    Framework • revision d408d302e2 (3 weeks ago) • 2020-09-29 11:49:17 -0700
    Engine • revision 5babba6c4d
    Tools • Dart 2.10.0
    

    Probably beta branch (?)

  19. balvinderz commented on Oct 23, 2020

    @balvinderz
    Contributor

    @Grohden this doesnt work in beta channel . You need to be on dev or master channel

  20. nilsreichardt commented on Dec 9, 2020

    @nilsreichardt
    Contributor

    Short question: What is the difference between package_info and package_info_plus? Why did not implemented this feature for package_info?

  21. balvinderz commented on Dec 10, 2020

    @balvinderz
    Contributor

    @Grohden this doesnt work in beta channel . You need to be on dev or master channel

    This now works in beta and stable branch too .

  22. guidezpl commented on May 25, 2021

    @guidezpl
    Member

    @nilsreichardt See #83277 for more context

  23. marceloiavenissi commented on Jun 29, 2021

    @marceloiavenissi

    Short question: What is the difference between package_info and package_info_plus? Why did not implemented this feature for package_info?

    "Important: As of January 2021, the Flutter team is no longer accepting non-critical PRs for the original set of plugins in flutter/plugins, and instead they should be submitted in this project. You can read more about this announcement here. as well as in the Flutter 2 announcement blog post." - https://pub.dev/packages/package_info_plus

  24. github-actions commented on Jul 30, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  25. locked as resolved and limited conversation to collaborators on Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projectc: new featureNothing broken; request for a new capabilityc: proposalA detailed proposal for a change to Fluttercustomer: crowdAffects or could affect many people, though not necessarily a specific customer.p: package_infoThe PackageInfo pluginpackageflutter/packages repository. See also p: labels.platform-webWeb applications specifically

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions