Skip to content

Usage measurements might be counting a bot in Virginia #4709

Closed

Description

@sethladd

Looking at our analytics reports, I see high usage in Ashburn, Virginia. Perhaps this is a bot/Travis/etc ?

This is after we changed the UA number, so this is recent data.

Activity

  1. added
    toolAffects the "flutter" command-line tool. See also t: labels.
    on Jun 22, 2016
  2. sethladd commented on Jun 22, 2016

    @sethladd
    ContributorAuthor

    cc @devoncarew is it possible we install flutter when we build the website? I'm trying to think of other CI-type systems we might have running. Chrome infra?

  3. sethladd commented on Jun 22, 2016

    @sethladd
    ContributorAuthor

    Ah, it's here: https://github.com/flutter/website/blob/master/tool/travis.sh#L23

    Would we be filtering this out already?

    I doubt this is the source of the big numbers, because we don't trigger builds of the website often. But still might be counted... ?

  4. devoncarew commented on Jun 22, 2016

    @devoncarew
    Contributor

    This should be filtered with our generic TRAVIS exclusion, but it can't hurt to exclude it specifically in it's travis.sh script.

    Perhaps we're counting bots from other people's CI systems? People developing Flutter apps?

  5. devoncarew commented on Jun 22, 2016

    @devoncarew
    Contributor

    (flutter config --no-analytics)

  6. eseidelGoogle commented on Jun 23, 2016

    @eseidelGoogle
    Contributor

    I don't think it's that call which is causing this:
    screen shot 2016-06-23 at 11 11 17 am

  7. eseidelGoogle commented on Jun 23, 2016

    @eseidelGoogle
    Contributor

    https://build.chromium.org/p/client.flutter/builders/Mac/builds/1270/steps/test%20create/logs/stdio is one step where our waterfall bots call create, however I don't believe those are located in virginia. Also CHROME_HEADLESS is clearly defined in the environment there, although it's possible that our environment override is blocking that for the call?

    I don't understand why it's just create and analyze?

    The above builder does not call analyze. :) But I know of no other builder of ours which uses create.

  8. eseidelGoogle commented on Jun 23, 2016

    @eseidelGoogle
    Contributor

    I asked @abarth and he pointed me to:
    https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/create_test.dart
    Which is likely the culprit. I'm sure we clear the environment before calling flutter, so we don't know we're on travis there. :)

  9. sethladd commented on Jun 23, 2016

    @sethladd
    ContributorAuthor

    Thanks for the investigation!

  10. devoncarew commented on Jun 23, 2016

    @devoncarew
    Contributor

    I'll fire off a PR -

  11. self-assigned this
    on Jun 23, 2016
  12. devoncarew commented on Jun 24, 2016

    @devoncarew
    Contributor

    Looking into this, it does look like the tests are using instances of MockUsage - a mock class that doesn't send any analytics.

  13. removed their assignment
    on Jun 24, 2016
  14. sethladd commented on Jul 11, 2016

    @sethladd
    ContributorAuthor

    Thanks for taking a look at this. Any luck?

  15. added this to the milestone on Sep 12, 2016
  16. 17 remaining items

  17. added this to the April 2020 milestone on Feb 11, 2020
  18. zanderso commented on Feb 11, 2020

    @zanderso
    Member

    This is still happening, although from a different town in Virginia. I am taking a look.

  19. modified the milestones: April 2020, on May 5, 2020
  20. zanderso commented on May 6, 2020

    @zanderso
    Member

    Monitoring the 1.17 stable release for reports from bots.

  21. modified the milestones: , May 2020 on May 6, 2020
  22. added
    P1High-priority issues at the top of the work list
    on May 29, 2020
  23. modified the milestones: 1.18 - May 2020, on Jun 2, 2020
  24. zanderso commented on Jun 3, 2020

    @zanderso
    Member

    These have dropped off. Closing.

  25. github-actions commented on Aug 8, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  26. locked as resolved and limited conversation to collaborators on Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listfrom: studyReported in a UX studytoolAffects the "flutter" command-line tool. See also t: labels.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions