Repository navigation
Skia Gold service access from LUCI #49749
Description
We currently set a GOLD_SERVICE_ACCOUNT env variable on Cirrus, which is used to authorize access to the Gold service in case a golden image is update.
I heard LUCI has access to this service, but I'm not sure if auth is done in a similar fashion or if we need to change the code to account for this environment.
cc @Piinks
Activity
Piinks commentedon Jan 30, 2020
The
goldctltool can authorize without a service account from the Luci environment. We can probably just add aluciAuthmethod to theSkiaClientclass in addition to the existingauthmethod that uses the service account.IIRC,
goldctl auth --work-dir $workDir --luci-envfyi @kjlubick :)
kjlubick commentedon Jan 30, 2020
Yep, although I think it's just
--luci, instead of--luci-env. We read the credentials out of the LUCI_CONTEXT environment variable when this is setPiinks commentedon Jan 30, 2020
See #49815 which will add a method to the skia client to authorize using luci. :)
blasten commentedon Jan 30, 2020
@kjlubick Do you have an example call within an existing recipe on LUCI?
kjlubick commentedon Jan 30, 2020
https://github.com/google/skia-buildbot/blob/bcd52175909b0200ef5f2635ddff50685d70c4b0/golden/puppeteer-tests/upload-screenshots-to-gold.py#L88
lock commentedon Apr 4, 2020
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.