Skip to content

[web] unskip location history tests on Safari #50836

Closed
#173782
Closed
[web] unskip location history tests on Safari#50836
#173782
Labels
P2Important issues not at the top of the work lista: tests"flutter test", flutter_test, or one of our testsbrowser: edgeonly manifests in Edge (Chromium-based)c: contributor-productivityTeam-specific productivity, code health, technical debt.frameworkflutter/packages/flutter repository. See also f: labels.platform-webWeb applications specificallyteam-webOwned by Web platform teamtriaged-webTriaged by Web platform team

Description

@nturgut
nturgut
opened on Feb 14, 2020

Some tests in test/window_test.dart are skipped in Safari.

In Safari the test passes in isolation. However, when running all tests at once, the whole batch fails. It's hard to tell why. There seems to be some cross-tests state pollution going on. Perhaps the issue is that tests run in an <iframe> and location history is modifying some global state.

Sample failure: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8804297826222711985/+/u/test:_Run_tests_on_macOS_Safari/stdout

Edit by @yjbanov: refined this bug report with more details.

Activity

  1. nturgut
    added
    platform-webWeb applications specifically
    on Feb 14, 2020
  2. nturgut
    added this to the milestone on Feb 14, 2020
  3. kf6gpe
    added
    P1High-priority issues at the top of the work list
    on May 29, 2020
  4. kf6gpe
    removed this from the milestone on Jun 1, 2020
  5. yjbanov
    added
    P2Important issues not at the top of the work list
    and removed
    P1High-priority issues at the top of the work list
    on Jun 16, 2020
  6. iapicca
    added
    a: tests"flutter test", flutter_test, or one of our tests
    browser: edgeonly manifests in Edge (Chromium-based)
    frameworkflutter/packages/flutter repository. See also f: labels.
    on Jul 6, 2020
  7. kf6gpe
    modified the milestone: on Jul 7, 2020
  8. kf6gpe
    removed this from the milestone on Jul 22, 2020
  9. Hixie
    removed this from the milestone on Aug 17, 2020
  10. markusaksli-nc
    added
    passed first triage
    c: contributor-productivityTeam-specific productivity, code health, technical debt.
    on Sep 21, 2020

  11. 12 remaining items

  12. flutter-triage-bot
    added
    team-webOwned by Web platform team
    triaged-webTriaged by Web platform team
    on Jul 8, 2023
  13. Hixie
    removed
    passed first triage
    on Jul 8, 2023
  14. Hixie
    removed
    multiteam-retriage-candidate
    on Mar 6, 2024
  15. github-merge-queue
    added a commit that references this issue on Aug 14, 2025

    [web] Cleanup usages of deprecated `routeUpdated` message (#173782)

    62904ba
  16. auto-submit
    closed this as completedin #173782on Aug 14, 2025
  17. ksokolovskyi
    added a commit that references this issue on Aug 19, 2025

    [web] Cleanup usages of deprecated `routeUpdated` message (flutter#17…

    c4bf640
  18. SydneyBao
    added 2 commits that reference this issue on Aug 22, 2025

    [web] Cleanup usages of deprecated `routeUpdated` message (flutter#17…

    89fd9a5

    [web] Cleanup usages of deprecated `routeUpdated` message (flutter#17…

    4376eaf

  19. github-actions commented on Aug 29, 2025

    @github-actions
    github-actionsbot
    on Aug 29, 2025 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  20. github-actions
    locked as resolved and limited conversation to collaborators on Aug 29, 2025
  21. mboetger
    added a commit that references this issue on Sep 18, 2025

    [web] Cleanup usages of deprecated `routeUpdated` message (flutter#17…

    399dfa4
  22. korca0220
    added a commit that references this issue on Sep 22, 2025

    [web] Cleanup usages of deprecated `routeUpdated` message (flutter#17…

    ae999be
  23. lucaantonelli
    added a commit that references this issue on Nov 21, 2025

    [web] Cleanup usages of deprecated `routeUpdated` message (flutter#17…

    5e03cf0
  24. Nakiha
    added a commit that references this issue on Sep 28, 2026

    [web] Cleanup usages of deprecated `routeUpdated` message (#173782)

    6da3e4f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work lista: tests"flutter test", flutter_test, or one of our testsbrowser: edgeonly manifests in Edge (Chromium-based)c: contributor-productivityTeam-specific productivity, code health, technical debt.frameworkflutter/packages/flutter repository. See also f: labels.platform-webWeb applications specificallyteam-webOwned by Web platform teamtriaged-webTriaged by Web platform team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions