Skip to content

Gallery, Persistent bottom sheet: FAB doesn't do anything #5092

Closed

Description

@sethladd

Open Gallery, tap into persistent bottom sheet, and notice the FAB there.

  • In Dark theme, the button is still Red. Should it change color?
  • Tapping the FAB does nothing. No ripple.

Do we keep the FAB? If so, why? It might make sense to remove it, unless we are showing how a FAB can move up in the presence of a persistent bottom sheet. If we keep it, can it ripple?

Activity

  1. added
    customer: galleryRelating to flutter/gallery repository. Please transfer non-framework issues there.
    on Jul 27, 2016
  2. HansMuller commented on Jul 27, 2016

    @HansMuller
    Contributor

    unless we are showing how a FAB can move up in the presence of a persistent bottom sheet

    Yes, that's why it's there.

  3. sethladd commented on Jul 27, 2016

    @sethladd
    ContributorAuthor

    Can we make it ripple on touch?

  4. HansMuller commented on Jul 27, 2016

    @HansMuller
    Contributor

    Not sure what ripple effect you're referring to?

  5. Hixie commented on Jul 27, 2016

    @Hixie
    Contributor

    the splash on the FAB, i assume.

    The FAB should have a default action of popping up a snack bar saying it does nothing, or some such.

  6. sethladd commented on Jul 28, 2016

    @sethladd
    ContributorAuthor

    Apologies. I meant "splash" when I said "ripple".

  7. modified the milestone: on Sep 12, 2016
  8. added
    frameworkflutter/packages/flutter repository. See also f: labels.
    on Sep 12, 2016
  9. Hixie commented on Feb 2, 2017

    @Hixie
    Contributor

    It ripples and shows a dialog now.

  10. added a commit that references this issue on May 14, 2018
  11. github-actions commented on Aug 15, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  12. locked as resolved and limited conversation to collaborators on Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    customer: galleryRelating to flutter/gallery repository. Please transfer non-framework issues there.frameworkflutter/packages/flutter repository. See also f: labels.from: reviewReported in the press

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions