Repository navigation
Gallery, Pesto: back button does nothing after going home from drawer #5103
Description
- Open gallery
- Tap pesto
- Tap to open drawer
- Tap home
- Tap recipe
- Hit the back button
- Hit the back button
- Hit the back button
On that third back button, I'd expect to be taken to the Gallery home. Instead, nothing happens.
On the fourth tap on the back button, I am taken back to the homescreen.
Activity
mpcomplete commentedon Jul 29, 2016
The problem with this one (even after Jason's crash fix) is that when you tap
Homefrom the open Drawer, the Drawer is never closed - just destroyed. This leaves the drawer-opening on the navigation stack, so you need to hitbackan extra time to skip past it.Maybe the Drawer should close itself when disposed.
Remove drawer history entry when drawer is disposed. (#5157)
jason-simmons commentedon Jul 30, 2016
This is happening because the tap of "Home" is considered a navigation that pushes another instance of Pesto onto the history stack.
When you hit the back button, you navigate from the second instance of Pesto back to the first. You can see the change if you scroll the recipe list in the two instances to different places. In your example, the two instances looked identical, so it seems like the back button did nothing.
If you're already in Home, then should another tap of Home in the drawer do anything?
Hixie commentedon Jul 30, 2016
@HansMuller was looking at this today.
On Fri, Jul 29, 2016, 5:10 PM Jason Simmons [email protected]
wrote:
HansMuller commentedon Aug 1, 2016
I have most of a fix. Hope to finish today. I filed a separate issue: #5159
Roll engine to e11905c.
Roll engine to e11905c. (#17026)
Roll engine to e11905c. (flutter#17026)
github-actions commentedon Sep 6, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.