Skip to content

Move away from cached tear-off closures for performance #5154

Closed

Description

@Hixie

@fsc8000 reports:

  1. Megamorphic calls have caught up in speed -- the transformation done for
    RenderObject.performLayout is not needed anymore, even slightly
    counter-productive in the AOT case: 1% speedup by reverting to a normal
    instance call according to my measurements.

cc @abarth

Activity

  1. modified the milestone: on Sep 12, 2016
  2. added
    frameworkflutter/packages/flutter repository. See also f: labels.
    on Sep 12, 2016
  3. added
    c: performanceRelates to speed or footprint issues (see "perf:" labels)
    on Jan 26, 2017
  4. modified the milestones: 2: Make Early Adopters happy, on Jan 26, 2017
  5. Hixie commented on Jan 26, 2017

    @Hixie
    ContributorAuthor

    This would also speed up reassemble substantially since a lot of the work of reassembling is updating these closure pointers.

    cc @johnmccutchan

  6. self-assigned this
    on Jan 27, 2017
  7. github-actions commented on Sep 5, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  8. locked as resolved and limited conversation to collaborators on Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

c: performanceRelates to speed or footprint issues (see "perf:" labels)frameworkflutter/packages/flutter repository. See also f: labels.waiting for PR to land (fixed)A fix is in flight

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions