Skip to content

Gallery, Pesto: FAB has square shadow while transitioning up #5203

Closed
Closed
Gallery, Pesto: FAB has square shadow while transitioning up#5203
Assignees
chinmaygarde
Labels
customer: galleryRelating to flutter/gallery repository. Please transfer non-framework issues there.dependency: skiaSkia team may need to help usengineflutter/engine related. See also e: labels.from: reviewReported in the press
Milestone
2: Make Early Adopters happy

Description

@sethladd
sethladd
opened on Aug 3, 2016

Please see this movie, from my Nexus 5X: https://youtu.be/VC6spk7P6Xg

Notice how the FAB, while transitioning up, has a square shadow around it. It doesn't have the square the entire transition, but starting at second 3 of the transition.

Activity

  1. sethladd
    added
    ⚠ bug
    engineflutter/engine related. See also e: labels.
    on Aug 3, 2016

  2. abarth commented on Aug 3, 2016

    @abarth
    abarth
    on Aug 3, 2016
    Contributor

    This is a bug in Skia. We ask skia what the bounding box of the fab is and it reports a size that goes out some number of standard deviations into the shadow but not sufficiently far to avoid this artifact.

  3. eseidelGoogle
    added
    dependency: skiaSkia team may need to help us
    on Aug 3, 2016

  4. sethladd commented on Aug 3, 2016

    @sethladd
    sethladd
    on Aug 3, 2016
    ContributorAuthor

    Thanks for the quick diagnosis. It's hard to notice at full speed, so probably not a high priority right now. If we know the Skia bug, we can link it here.

  5. abarth commented on Aug 3, 2016

    @abarth
    abarth
    on Aug 3, 2016
    Contributor

    I don't think I've filed it against skia yet. We should probably make a reduced test case for them.

  6. joeblew99 commented on Aug 5, 2016

    @joeblew99
    joeblew99
    on Aug 5, 2016

    @sethladd
    The video is an awesome way of documenting issues.
    How did you do the video screen capture ?

  7. eseidelGoogle commented on Aug 5, 2016

    @eseidelGoogle
    eseidelGoogle
    on Aug 5, 2016
    Contributor

    Personally I use:

    adb screenrecord /data/demo.mp4
adb pull /data/demo.mp4

    Then send it to YouTube and file bug. :) #3496 is on file about making that easier (and iOS enabled).

  8. sethladd commented on Aug 8, 2016

    @sethladd
    sethladd
    on Aug 8, 2016
    ContributorAuthor

    What @eseidelGoogle said :)

  9. Hixie
    modified the milestone: on Sep 12, 2016

  10. joeblew99 commented on Sep 29, 2016

    @joeblew99
    joeblew99
    on Sep 29, 2016

    @eseidelGoogle nice thanks

  11. Hixie
    removed
    old: bug (tell Hixie today if you don't want this label deleted)
    on Jan 12, 2017
  12. sethladd
    added
    from: reviewReported in the press
    on Jan 27, 2017

  13. sethladd commented on Jan 27, 2017

    @sethladd
    sethladd
    on Jan 27, 2017
    ContributorAuthor

    This came up in a review from our material design team.

  14. eseidelGoogle
    modified the milestones: 2: Make Early Adopters happy, on Feb 2, 2017

  15. eseidelGoogle commented on Feb 2, 2017

    @eseidelGoogle
    eseidelGoogle
    on Feb 2, 2017
    Contributor

    Considering for M2 since this showed up in UX review.

  16. sethladd commented on Feb 2, 2017

    @sethladd
    sethladd
    on Feb 2, 2017
    ContributorAuthor

    I'm not sure this is Pesto specific, so it might show an issue in our framework/engine. If so, M2 feels right.

  17. sethladd commented on Mar 8, 2017

    @sethladd
    sethladd
    on Mar 8, 2017
    ContributorAuthor

    hi @chinmaygarde ! Do we think this is addressed? (just doing a little cleanup)

  18. sethladd
    added
    customer: galleryRelating to flutter/gallery repository. Please transfer non-framework issues there.
    on Mar 17, 2017

  19. eseidelGoogle commented on Apr 11, 2017

    @eseidelGoogle
    eseidelGoogle
    on Apr 11, 2017
    Contributor

    @chinmaygarde any update? Is this the same as the other raster cache/shadow flash bug?

  20. chinmaygarde commented on Apr 11, 2017

    @chinmaygarde
    chinmaygarde
    on Apr 11, 2017
    Contributor

    This is a duplicate of the raster cache issue being tracked here in Flutter and here in Skia.

  21. eseidelGoogle
    assigned
    chinmaygarde
    on Apr 18, 2017

  22. eseidelGoogle commented on Apr 25, 2017

    @eseidelGoogle
    eseidelGoogle
    on Apr 25, 2017
    Contributor

    @chinmaygarde This is fixed now, right?

  23. eseidelGoogle commented on May 2, 2017

    @eseidelGoogle
    eseidelGoogle
    on May 2, 2017
    Contributor

    @chinmaygarde this is fixed, correct?

  24. chinmaygarde commented on May 5, 2017

    @chinmaygarde
    chinmaygarde
    on May 5, 2017
    Contributor

    As mentioned earlier, the underlying issue was the same as that in #5231. However, in recent versions of the gallery, the raster cache does not seem to be considering this FAB for caching (maybe because the picture layer boundary was introduced at a higher level). So yes, this is "fixed". But the correct fix is the one applied for #5231.

  25. chinmaygarde
    closed this as completedon May 5, 2017

  26. github-actions commented on Sep 5, 2021

    @github-actions
    github-actionsbot
    on Sep 5, 2021

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  27. github-actions
    locked as resolved and limited conversation to collaborators on Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

customer: galleryRelating to flutter/gallery repository. Please transfer non-framework issues there.dependency: skiaSkia team may need to help usengineflutter/engine related. See also e: labels.from: reviewReported in the press

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions