Skip to content

[animations] SharedAxisTransition resets ongoing animations after SharedAxisTransition page transition is complete #55826

Closed
flutter/packages
#160

Description

@vasilich6107

Hi. Thanks for the animations package. I've found unexpected renders in shared axis transition.

While moving forward it makes 3 component renders and only one while going back.
Here is how it look in while logging https://tppr.me/KSBAK

The logs are based on the bundled example.

Is this ok behaviour or we can somehow omit the additional _CoursePage build?

Activity

  1. TahaTesser commented on Apr 28, 2020

    @TahaTesser
    Contributor

    Hi @vasilich6107
    As far i know, builder function being multiple times is perfectly normal. It's just trying to stay updated
    You can try in separate, it will have same behaviour

    Please see https://flutter.dev/community for resources and asking questions like this, you may also get some help if you post it on Stack Overflow.
    Closing, as this isn't an issue with Flutter itself,
    if you disagree please write in the comments and I will reopen it
    Thank you

  2. vasilich6107 commented on Apr 28, 2020

    @vasilich6107
    ContributorAuthor

    @TahaTesser
    If I have something on the second card which I show with SharesAxisTransition it will render twice.
    It could result in two network requests, jiggling spinner(restarts from initial animation on each rerender...)

    I'm just trying to understand is this a bug in animations(https://pub.dev/packages/animations) library or this is ok behaviour...

  3. vasilich6107 commented on Apr 28, 2020

    @vasilich6107
    ContributorAuthor

    I made this video to illustrate what I'm talking about.
    In this extra slow-motion you can definitely see how spinners on courses list after making almost full circle just reseted to the initial animation. This is caused by the second in a row animation illustrated here https://tppr.me/KSBAK

    ezgif com-video-to-gif (2)

  4. vasilich6107 commented on Apr 28, 2020

    @vasilich6107
    ContributorAuthor

    May be the authors(@shihaohong, @goderbauer) of that transition could comment on this issue?

  5. vasilich6107 commented on Apr 28, 2020

    @vasilich6107
    ContributorAuthor

    Thanks a lot @TahaTesser 👍

  6. added
    packageflutter/packages repository. See also p: labels.
    on Apr 29, 2020
  7. changed the title [-]Animations package, SharedAxisTransition, extra renders[/-] [+][animations] SharedAxisTransition resets ongoing animations after SharedAxisTransition page transition is complete[/+] on May 6, 2020
  8. vasilich6107 commented on May 8, 2020

    @vasilich6107
    ContributorAuthor

    flutter/packages#141
    is the right PR to follow while awaiting the fix

  9. self-assigned this
    on May 20, 2020
  10. github-actions commented on Aug 20, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  11. locked as resolved and limited conversation to collaborators on Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

a: qualityA truly polished experiencep: animationsThe animations packagepackageflutter/packages repository. See also p: labels.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions