TextStyle with existing height cannot be copied with height=null #58765

Activity

1. iapicca

   added

   frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.

   P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter project

   c: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutter

   c: new featureNothing broken; request for a new capabilityNothing broken; request for a new capability

   on Jun 5, 2020
2. pedromassangocode

   added

   passed first triage

   on Mar 1, 2021
3. daohoangson commented on Jan 31, 2022

   

   daohoangson

   on Jan 31, 2022

   ContributorAuthor

   More actions

   Another way to do this without introducing a new param: use a private constant as the default value for height. That way we can determine exactly whether the caller specified some value for height during copy. There is one downsize though, the method signature will have to replace double? height with dynamic height = _default.
4. daohoangson commented on Jun 10, 2023

   

   daohoangson

   on Jun 10, 2023

   ContributorAuthor

   More actions

   TextStyle.height shouldn't be negative (it won't render anything), can we use a magic value of -1 to reset the height to null? Better yet, we can do an assert for TextStyle.new to disallow negative value and in TextStyle.copyWith, any negative value will reset the height.
5. flutter-triage-bot

   added

   team-frameworkOwned by Framework teamOwned by Framework team

   triaged-frameworkTriaged by Framework teamTriaged by Framework team

   on Jul 8, 2023
6. Hixie

   removed

   passed first triage

   on Jul 8, 2023
7. LongCatIsLooong

   added

   P2Important issues not at the top of the work listImportant issues not at the top of the work list

   and removed

   P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter project

   on Jan 12, 2024
8. LongCatIsLooong

   self-assigned this

   on Jan 12, 2024
9. LongCatIsLooong commented on Jan 12, 2024

   

   LongCatIsLooong

   on Jan 12, 2024

   Last edited by LongCatIsLooong

   Contributor

   More actions

   It's not only copyWith that is not working. The meaning of null is ambiguous in the TextStyle context:

   1. it could mean the value should inherit from the parent span, or be overwritten when TextStyle.merge is called, or
   2. the height multiplier is disabled.

   I think we should follow the TextStyle convention and assume 1, let null represent "inherited", and pick a magic value for "disabled".

   The other TextStyle class from dart:ui has the same problem.
10. daohoangson commented on Jan 12, 2024

    

    daohoangson

    on Jan 12, 2024

    ContributorAuthor

    More actions

    let null represent "inherited", and pick a magic value for "disabled"

    That would be great. Thank you.
11. flutter-triage-bot

    added

    ⏳Bot is counting down the days until it unassigns the issueBot is counting down the days until it unassigns the issue

    on May 17, 2024
12. flutter-triage-bot commented on May 17, 2024

    

    flutter-triage-botbot

    on May 17, 2024

    More actions

    This issue is assigned to @LongCatIsLooong but has had no recent status updates. Please consider unassigning this issue if it is not going to be addressed in the near future. This allows people to have a clearer picture of what work is actually planned. Thanks!
13. auto-submit

    added a commit that references this issue on May 24, 2024

    Allow unsetting `TextStyle.height` (#52940)

    ...

    f1505f5
14. auto-submit

    closed this as completedin #149049on May 29, 2024
15. auto-submit

    added a commit that references this issue on May 29, 2024

    Add a sentinel value for `TextStyle.height` (#149049)

    ...

    557fca4
16. victorsanni

    added a commit that references this issue on May 31, 2024

    Add a sentinel value for `TextStyle.height` (flutter#149049)

    ...

    27504dc
17. github-actions commented on Jun 12, 2024

    

    github-actionsbot

    on Jun 12, 2024 – with GitHub Actions

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
18. github-actions

    locked as resolved and limited conversation to collaborators on Jun 12, 2024