Repository navigation
[pigeon] display "common" Dart syntax issues before crashing #58897
Description
for instance
@FlutterApi()
abstract class Api {
foo();
}is invalid because there's no return type. But the error message from running pigeon is
Unhandled exception:
type '_SpecialTypeMirror' is not a subtype of type 'ClassMirror'
#0 Pigeon.parse (package:pigeon/pigeon_lib.dart:179:37)
#1 Pigeon.run (package:pigeon/pigeon_lib.dart:340:48)
#2 main (file:///Users/xster/development/samples/add_to_app/flutter_module_books/_pigeon_temp_.dart:7:21)
#3 _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:299:32)
#4 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:168:12)
pub finished with exit code 255
Wonder if there's a way to attach our own analysis_options.yaml for basic Dart linting.
cc @gaaclarke
Activity
stuartmorgan-g commentedon Oct 26, 2021
Was this fixed with the move away from mirrors?
gaaclarke commentedon Oct 26, 2021
It may for some cases. The example that was provided is not actually an error in Dart since not defining a return value can be valid and default to
dynamic. We get a null pointer exception when trying to get the return type. We could have a better error for that.