[pigeon] let Java FlutterApis be invoked with null callbacks

@gaaclarke

I had IDL with

@FlutterApi()
abstract class FlutterBookApi {
  void displayBookDetails(Book book);
}

it created Java code

public interface Reply<T> {
  void reply(T reply);
}
public void displayBookDetails(Book argInput, Reply<Void> callback) {
  BasicMessageChannel<Object> channel =
      new BasicMessageChannel<Object>(binaryMessenger, "dev.flutter.pigeon.FlutterBookApi.displayBookDetails", new StandardMessageCodec());
  HashMap inputMap = argInput.toMap();
  channel.send(inputMap, new BasicMessageChannel.Reply<Object>() {
    public void reply(Object channelReply) {
      callback.reply(null);
    }
  });
}

but if I don't care about the result, I can't pass null to callback since it doesn't null check and can crash.

cc @gaaclarke

What would be even better is if instead of null, you add overload method that just omits the callback.

@gaaclarke

@gaaclarke I don't think this ticket is relevant to the flutter/packages#222

This ticket is for the native APIs (such as Java APIs)

Sorry, keeping the languages straight has been a problem for me. Thanks for the heads up. I'll update the title.

[pigeon] allow callback of the flutter api method to be null

[pigeon] Improve java generation (#214)

Was this fixed by flutter/packages#214?

Was this fixed by flutter/packages#214?

Nope, you still have to provide a callback.

[pigeon] Improve java generation (flutter#214)

Navigation Menu

Repository navigation

[pigeon] let Java FlutterApis be invoked with null callbacks #58913

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[pigeon] let Java FlutterApis be invoked with null callbacks #58913

Description

Activity

matejdro commented on Sep 24, 2020

matejdro commented on Oct 12, 2020

gaaclarke commented on Oct 12, 2020

stuartmorgan-g commented on Oct 26, 2021

gaaclarke commented on Oct 26, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions