You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
FractionalOffset doesn't make sense in alignment cases. #5930
We should probably come up with a new class (Alignment?) that will be used in all cases where FractionalOffset is used to describe alignment, with all the statics (topLeft, center, etc.) transferred to the new type.
This seems to be a rather huge change/break. FractionalOffset used as an alignment is very popular. There's also an inconsistency in some constructors whether the parameter should be named align or alignment.
Ok, let's keep FractionalOffset as-is then. I'm not sure the Point/Offset distinction has helped us avoid any actual bugs and probably isn't worth replicating here.
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
Activity
dragostis commentedon Sep 19, 2016
This seems to be a rather huge change/break.
FractionalOffsetused as an alignment is very popular. There's also an inconsistency in some constructors whether the parameter should be namedalignoralignment.@Hixie @abarth
Hixie commentedon Sep 20, 2016
I guess what's really going on here is that we don't have a FractionalPoint.
I'm not entirely sold on the value of Point vs Offset so I'm probably not the best person to evaluate FractionalPoint vs FractionalOffset.
abarth commentedon Sep 21, 2016
Ok, let's keep FractionalOffset as-is then. I'm not sure the Point/Offset distinction has helped us avoid any actual bugs and probably isn't worth replicating here.
Roll engine a76054f..391ac2f (5 commits)
Roll engine a76054f..3b66f20 (6 commits)
Roll engine 4893b07..3b66f20 (4 commits)
github-actions commentedon Sep 6, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.