Potentially inaccurate surrogate pair detection #59513

Activity

1. justinmc

   self-assigned this

   on Jun 15, 2020
2. TahaTesser

   added

   a: typographyText rendering, possibly libtxtText rendering, possibly libtxt

   frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.

   passed first triage

   on Jun 16, 2020
3. lrhn commented on Jun 17, 2020

   

   lrhn

   on Jun 17, 2020

   Last edited by lrhn

   Contributor

   More actions

   The code is correct for what its name says it does: Surrogate detection. If the input is a UTF-16 code unit. The & 0xF800 maps every integer in the range 0xD800 through 0xDFFF to 0xD800.

   The only issue would be if the value was not in the range 0..0xFFFF, which means that ti's not a UTF-16 code unit. In that case you can use & ~0x7FF instead. It's probably just as efficient.

   The documentation seems to suggest that it can detect multi-codeunit glyphs. That is not correct, "e\u0301" or "\r\n" are multi-character glyphs that do not use surrogates.
4. justinmc commented on Jun 18, 2020

   

   justinmc

   on Jun 18, 2020

   ContributorAuthor

   More actions

   Note to self: see also #53381 (comment).
5. fluttergithubbot

   closed this as completedin #60219on Jun 24, 2020
6. github-actions commented on Aug 19, 2021

   

   github-actionsbot

   on Aug 19, 2021

   More actions

   This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
7. github-actions

   locked as resolved and limited conversation to collaborators on Aug 19, 2021